chore: re-enable nolintlint and typecheck linters

Drop startup/rand.go, as since Go 1.20 `rand.Seed` is done
automatically.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>

Author: smira

.golangci.yml

@@ -156,13 +156,11 @@ linters:
     - nestif
     - nilnil # we return "nil, nil"
     - nonamedreturns
-    - nolintlint
     - nosnakecase
     - paralleltest
     - promlinter # https://github.com/golangci/golangci-lint/issues/2222
     - tagliatelle # we have many different conventions
     - thelper
-    - typecheck
     - varnamelen # too annoying
     - wrapcheck
     - contextcheck # enable once golangci-lint 1.50.1 or 1.51 lands

cmd/installer/pkg/install/extensions.go

@@ -13,7 +13,6 @@ import (
 	"github.com/siderolabs/talos/pkg/machinery/constants"
 )
 
-// nolint:gocyclo
 func (i *Installer) installExtensions() error {
 	builder := extensions.Builder{
 		InitramfsPath:     fmt.Sprintf(constants.InitramfsAssetPath, i.options.Arch),

cmd/talosctl/cmd/mgmt/gen/config.go

@@ -287,7 +287,6 @@ func validateFlags() error {
 	return err
 }
 
-// nolint:gocyclo
 func writeConfigBundle(configBundle *bundle.Bundle, outputPaths configOutputPaths, commentsFlags encoder.CommentsFlags) error {
 	outputTypesSet := slices.ToSet(genConfigCmdFlags.outputTypes)
 

cmd/talosctl/main.go

@@ -9,13 +9,9 @@ import (
 	"os"
 
 	"github.com/siderolabs/talos/cmd/talosctl/cmd"
-	"github.com/siderolabs/talos/pkg/cli"
-	"github.com/siderolabs/talos/pkg/startup"
 )
 
 func main() {
-	cli.Should(startup.RandSeed())
-
 	if err := cmd.Execute(); err != nil {
 		os.Exit(1)
 	}

hack/cloud-image-uploader/main.go

@@ -8,12 +8,10 @@ package main
 import (
 	"context"
 	cryptorand "crypto/rand"
-	"encoding/binary"
 	"encoding/json"
 	"fmt"
 	"io"
 	"log"
-	"math/rand"
 	"os"
 	"path/filepath"
 	"sync"
@@ -77,8 +75,6 @@ func run() error {
 		log.Fatalf("error seeding rand: %s", err)
 	}
 
-	rand.Seed(int64(binary.LittleEndian.Uint64(seed))) //nolint:staticcheck
-
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
 

internal/app/apid/main.go

@@ -72,10 +72,6 @@ func apidMain() error {
 
 	startup.LimitMaxProcs(constants.ApidMaxProcs)
 
-	if err := startup.RandSeed(); err != nil {
-		return fmt.Errorf("failed to seed RNG: %w", err)
-	}
-
 	runtimeConn, err := grpc.Dial("unix://"+constants.APIRuntimeSocketPath, grpc.WithTransportCredentials(insecure.NewCredentials()))
 	if err != nil {
 		return fmt.Errorf("failed to dial runtime connection: %w", err)

internal/app/machined/internal/server/v1alpha1/v1alpha1_cluster.go

@@ -117,7 +117,7 @@ func (cl *clusterState) String() string {
 		}))
 }
 
-//nolint:gocyclo,cyclop
+//nolint:gocyclo
 func buildClusterInfo(ctx context.Context,
 	req *clusterapi.HealthCheckRequest,
 	r runtime.Runtime,

internal/app/machined/internal/server/v1alpha1/v1alpha1_server.go

@@ -297,8 +297,6 @@ func (s *Server) GenerateConfiguration(ctx context.Context, in *machine.Generate
 }
 
 // Reboot implements the machine.MachineServer interface.
-//
-//nolint:dupl
 func (s *Server) Reboot(ctx context.Context, in *machine.RebootRequest) (reply *machine.RebootResponse, err error) {
 	actorID := uuid.New().String()
 
@@ -330,8 +328,6 @@ func (s *Server) Reboot(ctx context.Context, in *machine.RebootRequest) (reply *
 }
 
 // Rollback implements the machine.MachineServer interface.
-//
-//nolint:gocyclo
 func (s *Server) Rollback(ctx context.Context, in *machine.RollbackRequest) (*machine.RollbackResponse, error) {
 	log.Printf("rollback via API received")
 
@@ -407,8 +403,6 @@ func (s *Server) Bootstrap(ctx context.Context, in *machine.BootstrapRequest) (r
 }
 
 // Shutdown implements the machine.MachineServer interface.
-//
-//nolint:dupl
 func (s *Server) Shutdown(ctx context.Context, in *machine.ShutdownRequest) (reply *machine.ShutdownResponse, err error) {
 	actorID := uuid.New().String()
 
@@ -563,7 +557,7 @@ func (opt *ResetOptions) GetSystemDiskTargets() []runtime.PartitionTarget {
 
 // Reset resets the node.
 //
-//nolint:gocyclo,cyclop
+//nolint:gocyclo
 func (s *Server) Reset(ctx context.Context, in *machine.ResetRequest) (reply *machine.ResetResponse, err error) {
 	actorID := uuid.New().String()
 
@@ -2229,7 +2223,7 @@ func (s *Server) PacketCapture(in *machine.PacketCaptureRequest, srv machine.Mac
 		if err = srv.SendMsg(&common.Data{Bytes: data}); err != nil {
 			cancel()
 
-			pr.CloseWithError(err) //nolint:errcheck
+			pr.CloseWithError(err)
 		}
 	}
 
@@ -2244,7 +2238,7 @@ func capturePackets(pw *io.PipeWriter, handle *pcapgo.EthernetHandle, snapLen ui
 	pcapw := pcapgo.NewWriterNanos(pw)
 
 	if err := pcapw.WriteFileHeader(snapLen, linkType); err != nil {
-		pw.CloseWithError(err) //nolint:errcheck
+		pw.CloseWithError(err)
 
 		return
 	}
@@ -2263,7 +2257,7 @@ func capturePackets(pw *io.PipeWriter, handle *pcapgo.EthernetHandle, snapLen ui
 		packet, err := pkgsrc.NextPacket()
 		if err == nil {
 			if err = pcapw.WritePacket(packet.Metadata().CaptureInfo, packet.Data()); err != nil {
-				pw.CloseWithError(err) //nolint:errcheck
+				pw.CloseWithError(err)
 
 				return
 			}
@@ -2286,7 +2280,7 @@ func capturePackets(pw *io.PipeWriter, handle *pcapgo.EthernetHandle, snapLen ui
 			errors.Is(err, io.ErrNoProgress) || errors.Is(err, io.ErrClosedPipe) || errors.Is(err, io.ErrShortBuffer) ||
 			errors.Is(err, syscall.EBADF) ||
 			strings.Contains(err.Error(), "use of closed file") {
-			pw.CloseWithError(err) //nolint:errcheck
+			pw.CloseWithError(err)
 
 			return
 		}

internal/app/machined/main.go

@@ -167,11 +167,6 @@ func run() error {
 	// Limit GOMAXPROCS.
 	startup.LimitMaxProcs(constants.MachinedMaxProcs)
 
-	// Ensure RNG is seeded.
-	if err := startup.RandSeed(); err != nil {
-		return err
-	}
-
 	// Set the PATH env var.
 	if err := os.Setenv("PATH", constants.PATH); err != nil {
 		return errors.New("error setting PATH")

internal/app/machined/pkg/controllers/cluster/discovery_service.go

@@ -273,7 +273,7 @@ func (ctrl *DiscoveryServiceController) Run(ctx context.Context, r controller.Ru
 					Affiliate: localData,
 					Endpoints: localEndpoints,
 				}, otherEndpoints); err != nil {
-					return fmt.Errorf("error setting local affiliate data: %w", err) //nolint:govet
+					return fmt.Errorf("error setting local affiliate data: %w", err)
 				}
 
 				prevLocalData = localData
@@ -312,7 +312,7 @@ func (ctrl *DiscoveryServiceController) Run(ctx context.Context, r controller.Ru
 
 				return nil
 			}); err != nil {
-				return err //nolint:govet
+				return err
 			}
 
 			touchedIDs[id] = struct{}{}