feat(lvm2): configure thin support

Enable `thin` option for LVM2. Fixes #833 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
siderolabs · Nov 20, 2023 · d59cb3e · d59cb3e
1 parent 252a59f
commit d59cb3e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 39 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -1,6 +1,6 @@
 # THIS FILE WAS AUTOMATICALLY GENERATED, PLEASE DO NOT EDIT.
 #
-# Generated on 2023-11-08T10:54:12Z by kres latest.
+# Generated on 2023-11-20T10:44:06Z by kres latest.
 
 name: default
 concurrency:
@@ -54,17 +54,6 @@ jobs:
               platforms: linux/arm64
           driver: remote
           endpoint: tcp://localhost:1234
-      - name: Save PR number
-        if: github.event_name == 'pull_request' && always()
-        run: |
-          echo ${{ github.event.number }} > pr-number.txt
-      - name: Upload PR number
-        if: github.event_name == 'pull_request' && always()
-        uses: actions/upload-artifact@v3
-        with:
-          name: pr-number
-          path: pr-number.txt
-          retention-days: "1"
       - name: Build
         run: |
           make
@@ -99,7 +88,7 @@ jobs:
                 repo: context.repo.repo,
             })
 
-            return resp.data.labels
+            return resp.data.labels.map(label => label.name)
       - name: release-notes
         if: startsWith(github.ref, 'refs/tags/')
         run: |
@@ -114,7 +103,7 @@ jobs:
     runs-on:
       - self-hosted
       - pkgs
-    if: contains(needs.default.outputs.labels, 'integration/reproducibility')
+    if: contains(fromJSON(needs.default.outputs.labels), 'integration/reproducibility')
     needs:
       - default
     services:

diff --git a/.github/workflows/slack-notify.yaml b/.github/workflows/slack-notify.yaml
@@ -1,6 +1,6 @@
 # THIS FILE WAS AUTOMATICALLY GENERATED, PLEASE DO NOT EDIT.
 #
-# Generated on 2023-11-08T10:54:12Z by kres latest.
+# Generated on 2023-11-20T10:44:06Z by kres latest.
 
 name: slack-notify
 "on":
@@ -17,33 +17,13 @@ jobs:
       - generic
     if: github.event.workflow_run.conclusion != 'skipped'
     steps:
-      - name: Download PR artifact
-        if: github.event.workflow_run.event == 'pull_request'
-        uses: actions/github-script@v6
-        with:
-          script: |-
-            let allArtifacts = await github.rest.actions.listWorkflowRunArtifacts({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                run_id: context.payload.workflow_run.id,
-            });
-            let matchArtifact = allArtifacts.data.artifacts.filter((artifact) => {
-                return artifact.name == "pr-number"
-            })[0];
-            let download = await github.rest.actions.downloadArtifact({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                artifact_id: matchArtifact.id,
-                archive_format: 'zip',
-            });
-            let fs = require('fs');
-            fs.writeFileSync(`${process.env.GITHUB_WORKSPACE}/pr-number.zip`, Buffer.from(download.data));
       - name: Get PR number
         id: get-pr-number
         if: github.event.workflow_run.event == 'pull_request'
+        env:
+          GH_TOKEN: ${{ github.token }}
         run: |
-          unzip pr-number.zip
-          echo pull_request_number=$(cat pr-number.txt) >> $GITHUB_OUTPUT
+          echo pull_request_number=$(gh pr view -R ${{ github.repository }} ${{ github.event.workflow_run.head_repository.owner.login }}:${{ github.event.workflow_run.head_branch }} --json number --jq .number) >> $GITHUB_OUTPUT
       - name: Slack Notify
         uses: slackapi/slack-github-action@v1
         with:

diff --git a/lvm2/pkg.yaml b/lvm2/pkg.yaml
@@ -23,7 +23,7 @@ steps:
         export PKG_CONFIG_PATH=/usr/lib/pkgconfig
 
         ./configure \
-             --with-thin=none \
+             --with-thin=internal \
              --with-cache=none \
              --disable-udev-systemd-background-jobs \
              --with-systemdsystemunitdir=/dev/null \