Add reset method #46
Merged
Add reset method #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great directive. Thank you. I'm new to this, so please don't hesitate to right a wrong. On countdown, I was looking for a reset function. PR above. Thoughts? |
|
I am looking at this PR. Is the use case is to reset the running countdown timer? |
|
Yes |
Added semicolon
|
Can you please include a test case for this? Preferably an html file under |
|
@siddii are you merging this anytime soon? |
|
OK, somehow this got missed. I am merging now. Let me know if everything looks fine after the merge. |
|
Its under v1.2.0 - https://github.com/siddii/angular-timer/releases/tag/v1.2.0 |
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined start and stop