Skip to content

Commit 4ae6985

Browse files
committed
tweaks
1 parent 1c8673f commit 4ae6985

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

register_decoder/decoder.py

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -136,16 +136,14 @@ def single_byte_decode(self, rw, b0):
136136
if rw == "WRITE":
137137
current_register = self.register_map[self.current_bank][b0]
138138
bitfields = self.load_bitfields(current_register)
139-
print("\n\tSETRD %s (%s)" % (self._reg_name(b0), self._h(b0)))
140139
self.prev_single_byte_write = b0
141140
else:
142141
current_register = self.register_map[self.current_bank][self.prev_single_byte_write]
143142
bitfields = self.load_bitfields(current_register)
144143
if (
145144
self.prev_single_byte_write != None
146145
): # isn't this always going to be set in this case? for normal register'd i2c yes.
147-
print("\t_READ %s (%s)" % (self._b(b0), self._h(b0)))
148-
print(
146+
debug_print(
149147
"%s read as %s (%s)"
150148
% (
151149
self._reg_name(self.prev_single_byte_write),
@@ -168,12 +166,10 @@ def decode_set_value(self, rw, reg_addr, value_byte):
168166
self.current_bank = value_byte >> 4
169167
return
170168
# ****IDENTIFIED WRITE TO REG W/ NEW VALUE ***
171-
print("SET %s to %s (%s)" % (self._reg_name(reg_addr), self._b(value_byte), self._h(value_byte)))
169+
debug_print("SET %s to %s (%s)" % (self._reg_name(reg_addr), self._b(value_byte), self._h(value_byte)))
172170
old_value = current_register['last_read_value']
173171

174-
print("")
175172
self.decode_by_bitfield(current_register, value_byte)
176-
print("")
177173

178174
def decode_by_bitfield(self, current_register, new_value):
179175
old_value = current_register['last_read_value']
@@ -193,17 +189,17 @@ def bitfield_change_str(self, bitfield, unset_bitmask, set_bitmask, new_value):
193189
change_str = None
194190
if bf_mask>>bf_shift == 0b1:
195191
if (bf_mask & unset_bitmask):
196-
change_str = "\t\t%s was unset"%bf_name
192+
change_str = "%s was unset"%bf_name
197193
if (bf_mask & set_bitmask):
198-
change_str = "\t\t%s was set"%bf_name
194+
change_str = "%s was set"%bf_name
199195
else:
200196
if (bf_mask & unset_bitmask) or (bf_mask & set_bitmask):
201197
bf_value = (bf_mask & new_value)>>bf_shift
202198
if bf_name in hardcoded_cvs:
203199
bf_value = hardcoded_cvs[bf_name][bf_value]
204200
else:
205201
bf_value = hex(bf_value)
206-
change_str = "\t\t%s was changed to %s"%(bf_name, bf_value)
202+
change_str = "%s was changed to %s"%(bf_name, bf_value)
207203

208204
return change_str
209205

@@ -217,7 +213,7 @@ def load_bitfields(self, current_register):
217213

218214
if not bitfield_name or (prev_bitfield_name == bitfield_name):
219215
continue
220-
# print("name:", bitfield_name, "mask: %s shift: %d"%(format(bitfield_mask,"#010b"), bitfield_shift))
216+
221217
bitfields.append((bitfield_name, bitfield_mask, bitfield_shift))
222218
prev_bitfield_name = bitfield_name
223219
current_register['bitfields'] = bitfields
@@ -231,7 +227,6 @@ def bitfield_def_to_bitfield(self, bitfield_def, shift):
231227
bf_end = int(bf_end)
232228
bf_start = int(bf_start)
233229
bitfield_mask = self.bitfield_range_to_mask(bf_start, bf_end)
234-
# SINGLE BIT W/ NAME
235230
else:
236231
bitfield_name = bitfield_def
237232
bitfield_mask = (1 << shift)

0 commit comments

Comments
 (0)