Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support array and refactor the expression template string #109

Merged
merged 4 commits into from
Jul 6, 2024

Conversation

si3nloong
Copy link
Owner

@si3nloong si3nloong commented Jul 6, 2024

Feature:

  • support fixed size array (rune and byte)
  • return error on types package when the type is unmatch

…t/array

# Conflicts:
#	codegen/tool.go
#	examples/examples_test.go
#	examples/testcase/struct-field/slice/generated.go
#	examples/testcase/struct-field/slice/generated.go.tpl
#	examples/testcase/struct-field/slice/model.go
@si3nloong si3nloong self-assigned this Jul 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 24.02235% with 136 lines in your changes missing coverage. Please review.

Project coverage is 14.02%. Comparing base (7eb9315) to head (66ef049).
Report is 2 commits behind head on main.

Files Patch % Lines
sequel/types/int.go 10.00% 26 Missing and 1 partial ⚠️
codegen/generator.go 0.00% 21 Missing ⚠️
codegen/tool.go 0.00% 16 Missing ⚠️
sequel/types/string.go 0.00% 11 Missing ⚠️
codegen/expr.go 64.00% 5 Missing and 4 partials ⚠️
sequel/types/bool.go 0.00% 8 Missing ⚠️
sequel/types/float.go 0.00% 8 Missing ⚠️
sequel/types/float_slice.go 0.00% 3 Missing ⚠️
sequel/types/int_slice.go 0.00% 3 Missing ⚠️
sequel/types/str_slice.go 0.00% 3 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   13.08%   14.02%   +0.94%     
==========================================
  Files          58       59       +1     
  Lines        2865     2958      +93     
==========================================
+ Hits          375      415      +40     
- Misses       2463     2511      +48     
- Partials       27       32       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@si3nloong si3nloong added bug Something isn't working enhancement New feature or request go Pull requests that update Go code breaking change A change that potentially causes other components to fail labels Jul 6, 2024
@si3nloong si3nloong added this to the BETA release milestone Jul 6, 2024
@si3nloong si3nloong linked an issue Jul 6, 2024 that may be closed by this pull request
@si3nloong si3nloong merged commit f0c5f12 into main Jul 6, 2024
3 checks passed
@si3nloong si3nloong deleted the feat/array branch July 6, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change that potentially causes other components to fail bug Something isn't working enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support array
2 participants