Fix resizeMode="cover" when image is resized (microsoft#1273)

* Fix resizeMode="cover" when image is resized

Since `RCTResizeModeCover` is implemented manually on macOS (iOS benefits from `UIViewContentModeScaleAspectFill` API), we need to reprocess the image any time the bounds of the view update. The `updateImage:` method was already called on resize, so this instead stores the original image in an ivar so it can call `RCTFillImagePreservingAspectRatio` from `updateImage:` instead.

* Fix rendering template images with tintColor

This fixes a regression introduced by the previous commit, where images would no longer render with the `tintColor` on release builds. We must call `setTemplate:` (using `.template` property is illegal in Objective-C++ since `template` is reserved in C++) on the newly resized image instead of the original image.

Confirmed icons look correct in the release build of Messenger Desktop.

Co-authored-by: Scott Kyle <skyle@fb.com>

Author: 2 people

Libraries/Image/RCTImageView.mm

@@ -128,6 +128,8 @@ @implementation RCTImageView
   // Whether the latest change of props requires the image to be reloaded
   BOOL _needsReload;
 
+  UIImage *_image; // TODO(macOS GH#774)
+
   RCTUIImageViewAnimated *_imageView;
 
 #if TARGET_OS_OSX // [TODO(macOS GH#774)
@@ -199,10 +201,6 @@ - (void)updateWithImage:(UIImage *)image
   if (_renderingMode != image.renderingMode) {
     image = [image imageWithRenderingMode:_renderingMode];
   }
-#else // [TODO(macOS GH#774)
-  if ((_renderingMode == UIImageRenderingModeAlwaysTemplate) != [image isTemplate]) {
-    [image setTemplate:(_renderingMode == UIImageRenderingModeAlwaysTemplate)];
-  }
 #endif // ]TODO(macOS GH#774)
 
   if (_resizeMode == RCTResizeModeRepeat) {
@@ -211,6 +209,10 @@ - (void)updateWithImage:(UIImage *)image
 #else // [TODO(macOS GH#774)
     image.capInsets = _capInsets;
     image.resizingMode = NSImageResizingModeTile;
+  } else if (_resizeMode == RCTResizeModeCover) {
+    if (!NSEqualSizes(self.bounds.size, NSZeroSize)) {
+      image = RCTFillImagePreservingAspectRatio(image, self.bounds.size, self.window.backingScaleFactor ?: 1.0);
+    }
 #endif // ]TODO(macOS GH#774)
   } else if (!UIEdgeInsetsEqualToEdgeInsets(UIEdgeInsetsZero, _capInsets)) {
     // Applying capInsets of 0 will switch the "resizingMode" of the image to "tile" which is undesired
@@ -222,6 +224,12 @@ - (void)updateWithImage:(UIImage *)image
 #endif // ]TODO(macOS GH#774)
   }
 
+#if TARGET_OS_OSX // [TODO(macOS GH#774)
+  if ((_renderingMode == UIImageRenderingModeAlwaysTemplate) != [image isTemplate]) {
+    [image setTemplate:(_renderingMode == UIImageRenderingModeAlwaysTemplate)];
+  }
+#endif // ]TODO(macOS GH#774)
+
   // Apply trilinear filtering to smooth out mis-sized images
   _imageView.layer.minificationFilter = kCAFilterTrilinear;
   _imageView.layer.magnificationFilter = kCAFilterTrilinear;
@@ -233,17 +241,13 @@ - (void)setImage:(UIImage *)image
 {
   image = image ?: _defaultImage;
   if (image != self.image) {
-#if TARGET_OS_OSX // [TODO(macOS GH#774)
-    if (image && _resizeMode == RCTResizeModeCover && !NSEqualSizes(self.bounds.size, NSZeroSize)) {
-      image = RCTFillImagePreservingAspectRatio(image, self.bounds.size, self.window.backingScaleFactor ?: 1.0);
-    }
-#endif // ]TODO(macOS GH#774)
+    _image = image; // TODO(macOS GH#774)
     [self updateWithImage:image];
   }
 }
 
 - (UIImage *)image {
-  return _imageView.image;
+  return _image ?: _imageView.image; // TODO(macOS GH#774)
 }
 
 - (void)setBlurRadius:(CGFloat)blurRadius