Skip to content

Latest commit

 

History

History
36 lines (29 loc) · 919 Bytes

ADD_DEPENDENCY.md

File metadata and controls

36 lines (29 loc) · 919 Bytes

Adding a New Dependency

Minikube uses Godep to manage vendored dependencies. Godep can be a bit finnicky with a project with this many dependencies. Here is a rough set of steps that usually works to add a new dependency.

  1. Make a clean GOPATH, with minikube in it. This isn't strictly necessary, but it usually helps.
mkdir -p $HOME/newgopath/src/k8s.io
export GOPATH=$HOME/newgopath
cd $HOME/newgopath/src/k8s.io
git clone https://github.com/kubernetes/minikube.git
  1. go get your new dependency.
go get mynewdepenency
  1. Use it in code, build and test.

  2. Import the dependency from GOPATH into vendor/

godep save ./...

If it is a large dependency, please commit the vendor/ directory changes separately. This makes review easier in Github.

git add vendor/
git commit -m "Adding dependency foo"
git add --all
git commit -m "Adding cool feature"