Skip to content

Commit 93d56e1

Browse files
njhillshreyankg
authored andcommitted
[V1][Minor] Remove obsolete FIXME comment (vllm-project#14304)
Signed-off-by: Nick Hill <nhill@redhat.com>
1 parent d775736 commit 93d56e1

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

vllm/v1/worker/gpu_input_batch.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -298,11 +298,6 @@ def add_request(
298298
if sampling_params.logit_bias is not None:
299299
self.logit_bias[req_index] = sampling_params.logit_bias
300300

301-
# FIXME: this implementation is incorrect. We create this mask
302-
# then apply -inf to these specific tokens, which means we never
303-
# select the allowed tokens! We cannot do the reverse, since
304-
# this will impact the requests that do not have allowed_token_ids.
305-
# This feature is currently disabled on V1 (we reject in Processor).
306301
if sampling_params.allowed_token_ids:
307302
self.has_allowed_token_ids.add(req_id)
308303
if self.allowed_token_ids_mask_cpu_tensor is None:

0 commit comments

Comments
 (0)