Closed
Conversation
FilipStamenkovic
force-pushed
the
showheroes-bidder
branch
from
027c254 to
ec93d7f
Compare
FilipStamenkovic
force-pushed
the
showheroes-bidder
branch
2 times, most recently
from
a6abac2 to
381563a
Compare
FilipStamenkovic
force-pushed
the
showheroes-bidder
branch
from
381563a to
dc69699
Compare
musikele
reviewed
Sep 12, 2025
| @Test | ||
| public void openrtb2AuctionShouldRespondWithBidsFromShowheroes() throws IOException, JSONException { | ||
| // given | ||
| WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/showheroes-exchange")) |
musikele
approved these changes
Sep 12, 2025
musikele
left a comment
musikele
left a comment
There was a problem hiding this comment.
Installed OpenJDK version 21.
run mvn clean package as instructed in the readme.
Unfortunately, test ShowheroesTest fails. It's hard to understand what causes that fail.
The approach we want to have here is to open the Prebid pull request and then fix with their CI, so I'm going to approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
showheroesbid adapter.Besides the standard openRTB request, the code does the following things:
siteor anappobjectsitemust have thepagepropertyappmust have thebundlepropertyunitIdmust be properly passed in theimpobjectimpobject must havevideoorbannerobject in itEURdisplaymanagerand version indisplaymanagerversource.ext.pbs