Skip to content

Conversation

julien-lang
Copy link
Contributor

@julien-lang julien-lang commented Jun 2, 2025

This pull request updates the azure-pipelines/tests.yml file to improve readability by renaming matrix keys for Python versions.

Before After
image image
image image

Relates to shotgunsoftware/sg-jira-bridge#93

@julien-lang julien-lang requested a review from Copilot June 2, 2025 20:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the test pipeline template to use a customizable job display name and refactors the Python version matrix keys for readability

  • Added displayName using a job_name parameter
  • Renamed matrix entries from Python39/Python310/Python311 to Python 3.9/3.10/3.11
Comments suppressed due to low confidence (2)

azure-pipelines-templates/run-tests.yml:40

  • The template now references parameters.job_name, but it isn't defined in this file. Either add a job_name parameter or revert to using the existing name parameter to avoid broken references.
displayName: ${{ parameters.job_name }}

azure-pipelines-templates/run-tests.yml:48

  • Matrix keys with spaces and dots may generate invalid job identifiers in Azure Pipelines. Consider using identifier-friendly keys (e.g., Python39) and moving the human-readable name into a displayName setting.
Python 3.9:

@julien-lang julien-lang changed the title Test Better CI Job Name Jun 2, 2025
@julien-lang julien-lang marked this pull request as ready for review June 2, 2025 21:51
@julien-lang julien-lang requested a review from Copilot June 2, 2025 21:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the readability of the CI matrix by renaming Python version keys to include dots and spaces, and updates related comments.

  • Updated comment examples to show version names with spaces and dots
  • Renamed strategy matrix keys from Python39, Python310, Python311 to Python 3.9, Python 3.10, Python 3.11
  • Adjusted comments above the job definition to match the new naming format

@julien-lang julien-lang requested a review from a team June 2, 2025 21:54
@julien-lang julien-lang merged commit cfab2b4 into master Jun 3, 2025
22 checks passed
@julien-lang julien-lang deleted the julien/test-improve-ci branch June 3, 2025 14:08
eduardoChaucaGallegos pushed a commit that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants