Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect pubspec versions on release for comparison with patch #2401

Open
eseidel opened this issue Aug 2, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@eseidel
Copy link
Contributor

eseidel commented Aug 2, 2024

It's somewhat common for users to not check in their pubspec.lock, and then end up with unexpected (sometimes native) changes to their packages.

https://docs.shorebird.dev/troubleshooting/#i-see-a-your-app-contains-native-changes-warning-when-running-shorebird-patch-even-though-i-havent-changed-swiftobjective-ckotlinjava-code

It might help if when we show a native warning, if we could show what pubspec versions have changed since the release.

Instead of saving the whole pubspec.lock (which might have paths in it), we could just save a map of package to version to be maximally privacy respecting.

@eseidel
Copy link
Contributor Author

eseidel commented Oct 10, 2024

#2407 is similar.

@eseidel eseidel added the enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant