refactor: Move logic for compiling shorebird.yaml into a new file #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also changed the logic from using a StringBuilder to using YamlEdit, that might change the output order of the yaml file but should *not* change the contents. I also added our first test of this logic. Next step is to make a `flutter shorebird compile-yaml` command or similar, and then have flutter.groovy call that so that we can share this logic between platforms and have a single place to edit when we need to make changes.
felangel
reviewed
Jul 26, 2024
| @@ -48,6 +33,8 @@ jobs: | |||
| # Fetch all branches and tags to ensure that Flutter can determine its version | |||
| fetch-depth: 0 | |||
|
|
|||
| # TODO(eseidel): shorebird_tests seems to assume flutter is available | |||
| # yet it doesn't seem to set it up here? | |||
felangel
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed the logic from using a StringBuilder to using YamlEdit, that might change the output order of the yaml file but should not change the contents.
I also added our first test of this logic.
Next step is to make a
flutter shorebird compile-yamlcommand or similar, and then have flutter.groovy call that so that we can share this logic between platforms and have a single place to edit when we need to make changes.