-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: "wrong" PHP 8.3 version installed when setup-php used twice in workflow #895
Comments
Please test if this happens even if you set update env to true in the setup-php step. |
I have identified why this happens. We have a logic to force update if the I will try to fix this in the next release that we maintain the update logic on subsequent runs in the same job, but the workaround to specify |
@shivammathur Thank you - as always - for your super-fast response. I've added a second commit to the reproduction branch and can confirm that adding the The thing I find weird about it, is that the issue only occured with PHP 8.3, not with any of the other PHP versions ? I very much appreciate that you are looking into the root cause of this, but yes, for my specific usecase, the update env will fix this. |
ubuntu-24.04 has php 8.3.6 preinstalled. |
@shivammathur Ah, that explains a lot! Thanks for letting me know. |
Fixed in cdfde5e. Will be in the next release. |
Released in |
Describe the bug
When installing PHP, setup-php will always install the latest released version of specific PHP minor.
The bug I'm currently seeing is one where this is not happening when setup-php is used twice in a workflow and the second time PHP 8.3 is being installed.
I've done some investigating and it looks like this issue only occurs with PHP 8.3.
This is a table with my findings (can be verified via the GH Actions logs link posted below):
Version
Runners
GitHub Hosted
Operating systems
ubuntu-latest
PHP versions
8.3
To Reproduce
I've testing the issue in isolation - a demo of the issue can be found here:
Expected behavior
I expected PHP 8.3.14 to be installed, but I got PHP 8.3.6 instead.
Screenshots/Logs
Additional context
Would love to submit a PR, but I searched the code base and couldn't find any direct clue as to why this is happening.
Are you willing to submit a PR?
No
The text was updated successfully, but these errors were encountered: