Skip to content

Security error when loaded within a nested iframe #3087

Open
@swaroopsm

Description

Firstly, thanks for this amazing library 🙇!

📝 Summary:
I currently use this in one of our products and recently discovered an issue when our web app was rendered within a nested iframe (by one of our customers). And when the user tries to start the tour, they get the following error:

Uncaught (in promise) SecurityError: Failed to read a named property 'frameElement' from 'Window': Blocked a frame with origin "https://www.shepherdjs.dev" from accessing a cross-origin frame.

I was able to reproduce this error by also embedding: https://www.shepherdjs.dev/ within a nested iframe

📸 Screenshot of the error image

🕵️ Steps to reproduce:

  • Create 2 .html pages (e.g.: index.html and shepherd.html)
  • Make sure these pages are accessible via localhost:<port>
  • In index.html, add an <iframe src="http://localhost:<port>/shepherd.html" />
  • In shepherd.html, add an <iframe src="https://www.shepherdjs.dev/" />
  • Try clicking on the "Demo" , the tour doesn't start and it errors out with the mentioned iframe security error on the browser console.

When I investigated the code, it seems like it was caused by an issue here and in general the browsers block to frames due to the Same-origin policy.

Would highly appreciate if any of you folks can help and add pointers to solve this. Thanks 🙏

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions