You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BrianSipple
changed the title
Add data attribute to the body for the currently active tour name
Add data attribute to the body for the currently active tour name and current step
Oct 25, 2018
@rwwagner90 @chuckcarpenter Since tours currently don't have a name or id property, I'm curious about your thoughts regarding how exactly we could design this.
One approach would be to allow for a name option to be passed to the Tour constructor, and then have the constructor set it as an instance property. If name isn't passed, Shepherd could generate a unique identifier for the Tour and use that.
From there, Tour._setupActiveTour could do something like this:
@BrianSipple I believe that is how id was supposed to work, but as Chuck noticed, it was always undefined. Perhaps we were not passing the right params to get it set, but I think your approach sounds good.
Following up on the discussion here
The text was updated successfully, but these errors were encountered: