Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minified js + css to release package #258

Closed
bbernhard opened this issue Sep 30, 2018 · 5 comments
Closed

Add minified js + css to release package #258

bbernhard opened this issue Sep 30, 2018 · 5 comments
Assignees

Comments

@bbernhard
Copy link

Hi,

could you maybe add a dist folder, containing the built js + css (+minified version) files, to the release package? I think that could be quite useful for a lot of people.

I've to admit, that I almost dropped shepherd, because I had to install npm to compile the sources first ;-)

Many thanks for the great library!

@RobbieTheWagner
Copy link
Member

@bbernhard you're writing a JS app without npm? I did not consider this as a use case.

@bbernhard
Copy link
Author

yeah, right. I am using a golang application to serve my webpages, so there was not really a need for me to install npm. :)

@RobbieTheWagner
Copy link
Member

@bbernhard I would argue that developing any sort of JS app basically requires npm these days and/or some type of build process to minify things for you.

You could use https://unpkg.com/#/ or something similar to have a link to the assets from npm. I will work on figuring out how to release the dist files as well though.

@RobbieTheWagner
Copy link
Member

@bbernhard we are now copying all dist files to the releases, hopefully this is helpful! https://github.com/shipshapecode/shepherd/releases/tag/v2.0.0-beta.32

@bbernhard
Copy link
Author

Definitely!

Thanks a lot, very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants