Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classPrefix breaks target blocking #1298

Open
npedrini opened this issue Jan 15, 2021 · 8 comments
Open

classPrefix breaks target blocking #1298

npedrini opened this issue Jan 15, 2021 · 8 comments

Comments

@npedrini
Copy link

If you specify a classPrefix in the tour options, any highlighted elements in steps where canClickTarget = true are still clickable because the following css selector breaks:

.shepherd-target-click-disabled.shepherd-enabled.shepherd-target,.shepherd-target-click-disabled.shepherd-enabled.shepherd-target *{
    pointer-events:none
}

The following custom css rule has to be added, taking into account the classPrefix:

.shepherd-target-click-disabled.walkthrough-shepherd-enabled.shepherd-target,.shepherd-target-click-disabled.walkthrough-shepherd-enabled.shepherd-target *{
    pointer-events:none
}
@RobbieTheWagner
Copy link
Member

@npedrini would you like to submit a PR adding class prefix support for this?

@stale
Copy link

stale bot commented Feb 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jun 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jul 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 13, 2021
@stale stale bot closed this as completed Jul 21, 2021
@edenriquez
Copy link

Is this issue still happening ? can I take it ?

@RobbieTheWagner
Copy link
Member

@edenriquez sure thing, please feel free to take it!

@arrfandannge
Copy link

Assuming that this issue is still reproducing since its marked open. Can i take it?

@RobbieTheWagner
Copy link
Member

@arrfandannge I am honestly not sure, but please feel free to investigate and take on the work if you would like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants