Drop UselessPrivatePropertyNullabilityRule (#283)

Author: janedbal

README.md

@@ -592,7 +592,7 @@ function example(MyClass $class) {
 
 ### forbidUselessNullableReturn
 - Denies marking closure/function/method return type as nullable when null is never returned
-- Recommended to be used together with `uselessPrivatePropertyDefaultValue` and `UselessPrivatePropertyNullabilityRule`
+- Recommended to be used together with `uselessPrivatePropertyDefaultValue`
 ```php
 public function example(int $foo): ?int { // null never returned
     if ($foo < 0) {
@@ -664,7 +664,7 @@ try {
 - Detects useless default value of a private property that is always initialized in constructor.
 - Cannot handle conditions or private method calls within constructor.
 - When enabled, return statements in constructors are denied to avoid false positives
-- Recommended to be used with `uselessPrivatePropertyNullability` and `forbidUselessNullableReturn`
+- Recommended to be used with `forbidUselessNullableReturn`
 ```php
 class Example
 {
@@ -677,29 +677,6 @@ class Example
 }
 ```
 
-### uselessPrivatePropertyNullability:
-- Detects useless nullability of a private property by checking type of all assignments.
-- Works only with natively typehinted properties
-- Recommended to be used with `uselessPrivatePropertyNullability` and `forbidUselessNullableReturn` as removing useless default value may cause useless nullability to be detected
-- PHPStan 1.12 with bleeding edge contains more generic version of this rule under `property.unusedType` error identifier
-
-```php
-class Example
-{
-    private ?int $field; // useless nullability
-
-    public function __construct()
-    {
-        $this->field = 1;
-    }
-
-    public function setField(int $value)
-    {
-        $this->field = $value;
-    }
-}
-```
-
 ## Native PHPStan extra strictness
 Some strict behaviour in PHPStan is not enabled by default, consider enabling extra strictness even there:
 

rules.neon

@@ -86,8 +86,6 @@ parameters:
             reportEvenIfExceptionIsNotAcceptableByRethrownOne: true
         uselessPrivatePropertyDefaultValue:
             enabled: %shipmonkRules.enableAllRules%
-        uselessPrivatePropertyNullability:
-            enabled: %shipmonkRules.enableAllRules%
 
 parametersSchema:
     shipmonkRules: structure([
@@ -212,9 +210,6 @@ parametersSchema:
         uselessPrivatePropertyDefaultValue: structure([
             enabled: bool()
         ])
-        uselessPrivatePropertyNullability: structure([
-            enabled: bool()
-        ])
     ])
 
 conditionalTags:
@@ -290,17 +285,13 @@ conditionalTags:
         phpstan.rules.rule: %shipmonkRules.requirePreviousExceptionPass.enabled%
     ShipMonk\PHPStan\Rule\UselessPrivatePropertyDefaultValueRule:
         phpstan.rules.rule: %shipmonkRules.uselessPrivatePropertyDefaultValue.enabled%
-    ShipMonk\PHPStan\Rule\UselessPrivatePropertyNullabilityRule:
-        phpstan.rules.rule: %shipmonkRules.uselessPrivatePropertyNullability.enabled%
 
     ShipMonk\PHPStan\Visitor\UnusedExceptionVisitor:
         phpstan.parser.richParserNodeVisitor: %shipmonkRules.forbidUnusedException.enabled%
     ShipMonk\PHPStan\Visitor\UnusedMatchVisitor:
         phpstan.parser.richParserNodeVisitor: %shipmonkRules.forbidUnusedMatchResult.enabled%
     ShipMonk\PHPStan\Visitor\TopLevelConstructorPropertyFetchMarkingVisitor:
         phpstan.parser.richParserNodeVisitor: %shipmonkRules.uselessPrivatePropertyDefaultValue.enabled%
-    ShipMonk\PHPStan\Visitor\ClassPropertyAssignmentVisitor:
-        phpstan.parser.richParserNodeVisitor: %shipmonkRules.uselessPrivatePropertyNullability.enabled%
 
 services:
     -
@@ -405,8 +396,6 @@ services:
         class: ShipMonk\PHPStan\Rule\ForbidReturnInConstructorRule
     -
         class: ShipMonk\PHPStan\Rule\UselessPrivatePropertyDefaultValueRule
-    -
-        class: ShipMonk\PHPStan\Rule\UselessPrivatePropertyNullabilityRule
 
     -
         class: ShipMonk\PHPStan\Rule\RequirePreviousExceptionPassRule
@@ -418,5 +407,3 @@ services:
         class: ShipMonk\PHPStan\Visitor\UnusedMatchVisitor
     -
         class: ShipMonk\PHPStan\Visitor\TopLevelConstructorPropertyFetchMarkingVisitor
-    -
-        class: ShipMonk\PHPStan\Visitor\ClassPropertyAssignmentVisitor