Trait entrypoint check in context of users (#54)

Author: janedbal

src/Collector/MethodDefinitionCollector.php

@@ -133,7 +133,7 @@ private function getDeclaringTraitDefinition(
             return null;
         }
 
-        if ($realDeclaringClass->isTrait()) {
+        if ($realDeclaringClass->isTrait() && $realDeclaringClass->getName() !== $classReflection->getName()) {
             return new MethodDefinition(
                 $realDeclaringClass->getName(),
                 $realName,

src/Rule/DeadMethodRule.php

@@ -215,8 +215,19 @@ private function isEntryPoint(MethodDefinition $methodDefinition): bool
             return false;
         }
 
-        $methodReflection = $this->reflectionProvider // @phpstan-ignore missingType.checkedException (method should exist)
-            ->getClass($methodDefinition->className)
+        $reflection = $this->reflectionProvider->getClass($methodDefinition->className);
+
+        // if trait has users, we need to check entrypoint even from their context
+        if ($reflection->isTrait()) {
+            foreach ($this->classHierarchy->getMethodTraitUsages($methodDefinition) as $traitUsage) {
+                if ($this->isEntryPoint($traitUsage)) {
+                    return true;
+                }
+            }
+        }
+
+        // @phpstan-ignore missingType.checkedException (method should exist)
+        $methodReflection = $reflection
             ->getNativeReflection()
             ->getMethod($methodDefinition->methodName);
 

tests/Rule/data/DeadMethodRule/providers/phpunit.php

@@ -7,8 +7,16 @@
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 
+trait TraitTestCase {
+    #[Before] // need to be checked in context of user, not in context of trait
+    public function callBefore(): void
+    {
+    }
+}
+
 class SomeTest extends TestCase
 {
+    use TraitTestCase;
 
     #[DataProvider('provideFromAttribute')]
     public function testFoo(string $arg): void