Skip to content

Commit e33688e

Browse files
notjoshide
authored andcommitted
Adds PrivateDatabase podspec
Summary: Resolves facebook#16663. Walked through the reproduction steps in facebook#16663, but with successful build. We can also now see the files are included in the `Pods` project: <img width="236" alt="screen shot 2017-11-03 at 7 43 21 pm" src="https://user-images.githubusercontent.com/33126/32390596-4a06c05c-c0cf-11e7-8616-3ae547f8cca2.png"> (I noticed a subspec called `_ignore_me_subspec_for_linting_` so do we have tests for the podspec?) [IOS] [BUGFIX] [React.podspec] - Resolves build error about missing symbols for PrivateDatabase.{cpp,h} Closes facebook#16664 Differential Revision: D6238178 Pulled By: hramos fbshipit-source-id: b57007ab8c7c8bd0faf1f2f11269a7a2c28183e5
1 parent 6ea6684 commit e33688e

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

React.podspec

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,19 @@ Pod::Spec.new do |s|
109109

110110
s.subspec "jschelpers" do |ss|
111111
ss.dependency "Folly", "2016.09.26.00"
112+
ss.dependency "React/PrivateDatabase"
112113
ss.compiler_flags = folly_compiler_flags
113114
ss.source_files = "ReactCommon/jschelpers/*.{cpp,h}"
114115
ss.private_header_files = "ReactCommon/jschelpers/*.h"
115116
ss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/ReactCommon\"" }
116117
ss.framework = "JavaScriptCore"
117118
end
118119

120+
s.subspec "PrivateDatabase" do |ss|
121+
ss.source_files = "ReactCommon/privatedata/*.{cpp,h}"
122+
ss.private_header_files = "ReactCommon/privatedata/*.h"
123+
end
124+
119125
s.subspec "cxxreact" do |ss|
120126
ss.dependency "React/jschelpers"
121127
ss.dependency "boost"

0 commit comments

Comments
 (0)