colab notebook shows outputs

[jcohenadad]

loading the colab (without running), i see the outputs (figure), eg:

we usually avoid commiting/pushing the notebooks outputs (binaries) as they inflate the git repos-- is this something required on the neurolibre side? @mathieuboudreau @agahkarakuzu @nstikov

[mathieuboudreau]

@jcohenadad this is my mistake - sorry about that. In the urgency of things yesterday, I forgot to clear the notebook before pushing it, and I didn't ask Agah to review the PR (he couldn't have anyways, he was on a flight). This isn't needed for neurolibre.

I can rectify this in the repo to remove the bloat, however I'm hesitant on doing this while the manuscript is in review (I think MRM only gives 2 weeks at this stage) to ensure that reviewers have working links. Resolving this will require me to roll back the commit that master points to and repush the changes from the latest PR, but with the notebook cleared (and either deleting the release and re-releasing under the same version name, or creating a new release)

Is it ok if we wait for the reviewer responses for me to fix this? The current version should work for the reviewers, it's just not optimal re:size as you said.

[jcohenadad]

@jcohenadad this is my mistake - sorry about that. In the urgency of things yesterday, I forgot to clear the notebook before pushing it, and I didn't ask Agah to review the PR (he couldn't have anyways, he was on a flight). This isn't needed for neurolibre.

no worries! I was just curious if it was a requirement for neurolibre (I'm still learning how the neurolibre workflow works). And it is a good example to demonstrate the intricacies of scaling up the workflow to publication workflow (ie: ironing out the details, dependence on human experts, etc.). Tagging @nstikov as this is relevant feedback from user

I can rectify this in the repo to remove the bloat, however I'm hesitant on doing this while the manuscript is in review (I think MRM only gives 2 weeks at this stage) to ensure that reviewers have working links. Resolving this will require me to roll back the commit that master points to and repush the changes from the latest PR, but with the notebook cleared (and either deleting the release and re-releasing under the same version name, or creating a new release)

Is it ok if we wait for the reviewer responses for me to fix this? The current version should work for the reviewers, it's just not optimal re:size as you said.

no need-- this repos won't be updated 1000 times a year. It will just sit around after publication.