fix(rehype): handle promise rejections in lazy language loading #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1221 +/- ##
=======================================
Coverage 95.20% 95.21%
=======================================
Files 92 92
Lines 7922 7936 +14
Branches 1689 1695 +6
=======================================
+ Hits 7542 7556 +14
Misses 374 374
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add test coverage for error handling paths when loadLanguage() fails: - Test with fallbackLanguage option - Test with onError callback - Test that throws when no fallback or onError provided This improves code coverage for the error handling code added in the previous commit.
- Fix type errors by using Parameters<typeof highlighter.loadLanguage> for mock - Remove unused 'file' variable in onError test case
antfu
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where promise rejections weren't properly handled when lazy-loading languages in the rehype transformer. If
loadLanguage()failed for any language, the rejection would propagate toPromise.all()without proper error handling, potentially causing unhandled promise rejections.Changes
.catch()handler to promises pushed to the queue when lazy-loading languagesfallbackLanguageoronErrorcallback when language loading failsTesting