Skip to content

Conversation

simplyNour
Copy link
Contributor

@simplyNour simplyNour commented Oct 10, 2025

Fixes: #2635

Current F+ test result for "Gradle"

Screenshot from 2025-10-10 06-36-11

After Fix

Screenshot from 2025-10-10 06-32-36

@simplyNour simplyNour requested a review from ppfeister as a code owner October 10, 2025 03:31
@simplyNour
Copy link
Contributor Author

@ppfeister
Can you please review this PR?
Also, let me know if you agree with the extended more fail-proof solution of updating the pipeline to catch failures that are due to python raised exceptions rather than test failures.
Thanks in advance.

@ppfeister
Copy link
Member

ppfeister commented Oct 11, 2025

Can't believe this wasn't caught yet. Good one!

Also, let me know if you agree with the extended more fail-proof solution of updating the pipeline to catch failures that are due to python raised exceptions rather than test failures.

Could you elaborate on this point?

Generally, pipelines should fail when an (unexpected) error is thrown, because that's the point of testing. Do you mean fixing it so that the site validation workflow fails properly? (catch normally implies a graceful fail and continue, so making sure we're on the same page)

(marked as hacktoberfest-accepted so it counts immediately, but waiting to merge based on above feedback in case this site is a good test case)

@ppfeister ppfeister self-assigned this Oct 11, 2025
@ppfeister ppfeister added bug Something isn't working hacktoberfest-accepted labels Oct 11, 2025
@ppfeister ppfeister added this to the v0.17.0 milestone Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python variable scoping issue when testing "Gradle"

2 participants