Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

ustas - Misleading gap size #1

Closed
github-actions bot opened this issue Feb 20, 2023 · 0 comments
Closed

ustas - Misleading gap size #1

github-actions bot opened this issue Feb 20, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Reward A payout will be made for this issue Specification An issue related to the specification (low severity)

Comments

@github-actions
Copy link

github-actions bot commented Feb 20, 2023

ustas

low

Misleading gap size

Summary

The gap size in the comments and the actual code are different; the size is incorrect in both variants.

Vulnerability Detail

According to the documentation, the gap's size should equal 44 because there are 6 used storage slots in the contract.

Impact

This is misleading and could impact future upgrades.

Code Snippet

https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/universal/CrossDomainMessenger.sol#L132-L137
https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/.storage-layout#L9-L45

Tool used

Manual Review, VSCodium

Recommendation

Change the size to 44.

Duplicate of #146

@github-actions github-actions bot added Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Specification An issue related to the specification (low severity) labels Feb 20, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Reward A payout will be made for this issue Specification An issue related to the specification (low severity)
Projects
None yet
Development

No branches or pull requests

1 participant