Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimist for CVE-2021-44906 #218

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Update minimist for CVE-2021-44906 #218

merged 1 commit into from
Nov 20, 2023

Conversation

tomhaines432
Copy link
Contributor

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

max-carroll-sky
max-carroll-sky approved these changes Nov 16, 2023
View reviewed changes
Copy link

@max-carroll-sky max-carroll-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nfischer nfischer merged commit 0dcbb9d into shelljs:main Nov 20, 2023
45 of 47 checks passed
@nfischer
Copy link
Member

Thanks for the contribution.

FYI I'm not planning to expedite a release for this issue because we previously used a semver range which is compatible with the patched version of minimist. Users installing shx on their machines should already receive the latest version of minimist which includes the patch.

This will of course be part of the next shx release whenever that does eventually happen.

@tomhaines432 tomhaines432 deleted the bump-minimist branch November 20, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-carroll-sky max-carroll-sky max-carroll-sky approved these changes

@nfischer nfischer nfischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomhaines432 @nfischer @max-carroll-sky