Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about upgrade to fdk-aac 2.0.x? #25

Closed
nkligang opened this issue Nov 21, 2023 · 7 comments
Closed

How about upgrade to fdk-aac 2.0.x? #25

nkligang opened this issue Nov 21, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@nkligang
Copy link

Do you have plan to upgrade to fdk-aac 2.0.x?

@sheinbergon sheinbergon self-assigned this Nov 23, 2023
@sheinbergon sheinbergon added the enhancement New feature or request label Nov 23, 2023
@sheinbergon
Copy link
Owner

sheinbergon commented Nov 23, 2023

Hi

I did give it a shot 2 years ago or so.

The upgrade is not trivial, as the structure/constructs have changed, so mapping/bindings should chnage as well.
I will be giving it a look in the near future, though can't commit to exactly when.
Is using 0.1.6 not an option for you?

@nkligang
Copy link
Author

Hi

I did give it a shot 2 years ago or so.

The upgrade is not trivial, as the structure/constructs have changed, so mapping/bindings should chnage as well. I will be giving it a look in the near future, though can't commit to exactly one. Is using 0.1.6 not an option for you?

Hi, thank you for your reply. Maybe 0.1.6 is enough for me.

@sheinbergon
Copy link
Owner

fdk-aac 0,1.6 works well, and there already matching jars in place (assuming you're not using apple silicon). Let me know if you encounter any issue

@nkligang
Copy link
Author

OK

@sheinbergon
Copy link
Owner

@nkligang so, good news. Your inquiry inspired me, and I think I got it working with 2.0.2 (think).
Which OS are you testing this code on?

@nkligang
Copy link
Author

@sheinbergon I'm very happy to hear that. I'm developer of TeamAssistor(https://www.teamassistor.com/), I found your project is because I encounter one issue: I encode audio aac using ffmpeg but failed decoding aac in Android using MediaCodec, I wonder the problem maybe is the fdk-acc algorithm, but finally I found it's not. So, fdk-aac is not need for me anymore. But the project really help me to find the solution. Thank you very much for your work!

@sheinbergon
Copy link
Owner

Fixed in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants