Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using faccess lib to detect executable files #1169

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Using faccess lib to detect executable files #1169

merged 2 commits into from
Nov 15, 2022

Conversation

Ptipiak
Copy link
Contributor

@Ptipiak Ptipiak commented Nov 11, 2022

tmccombs
tmccombs approved these changes Nov 12, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Ptipiak Ptipiak force-pushed the mention-executable-detection branch 3 times, most recently from 18f36ee to aad9a7c Compare November 12, 2022 20:10
tmccombs
tmccombs approved these changes Nov 13, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Ptipiak Ptipiak force-pushed the mention-executable-detection branch 2 times, most recently from 9a43077 to 6dc0a85 Compare November 13, 2022 12:54
sharkdp
sharkdp reviewed Nov 13, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
sharkdp
sharkdp reviewed Nov 13, 2022
View reviewed changes
src/cli.rs Outdated Show resolved Hide resolved
sharkdp
sharkdp reviewed Nov 13, 2022
View reviewed changes
src/filesystem.rs Outdated Show resolved Hide resolved
@Ptipiak Ptipiak force-pushed the mention-executable-detection branch 3 times, most recently from e28755d to 47208b3 Compare November 14, 2022 15:07
@Ptipiak
Using faccess lib to detect executable files
88bebb8 
* The detection of executable files was not exactly the same as
the original find
@sharkdp sharkdp merged commit 38cdeb0 into sharkdp:master Nov 15, 2022
@Ptipiak Ptipiak deleted the mention-executable-detection branch November 15, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tavianator tavianator tavianator left review comments

@tmccombs tmccombs tmccombs approved these changes

@sharkdp sharkdp sharkdp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

help: mention that fd detects executables by file permissions
4 participants
@Ptipiak @tavianator @tmccombs @sharkdp