Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load the entire file into memory #21

Closed
sharkdp opened this issue Oct 3, 2021 · 1 comment
Closed

Do not load the entire file into memory #21

sharkdp opened this issue Oct 3, 2021 · 1 comment

Comments

@sharkdp
Copy link
Owner

sharkdp commented Oct 3, 2021

This obviously causes OOM problems with very large files.

Maybe we can use mmap instead. But I'm not sure if we would sacrifice OS independence.

@sharkdp sharkdp changed the title Do not load the entire file to memory Do not load the entire file into memory Oct 3, 2021
@toolCHAINZ
Copy link
Contributor

I made a PR to attempt to fix this: #29

@sharkdp sharkdp closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants