Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PortisTransport, MetaMaskTransport, and XDeFiTransport are unnessecary #458

Closed
mrnerdhair opened this issue Mar 14, 2022 · 0 comments · Fixed by #422
Closed

PortisTransport, MetaMaskTransport, and XDeFiTransport are unnessecary #458

mrnerdhair opened this issue Mar 14, 2022 · 0 comments · Fixed by #422
Labels
tech-debt A suboptimality that existed in code when it was written.

Comments

@mrnerdhair
Copy link
Contributor

mrnerdhair commented Mar 14, 2022 •
edited
Loading

hdwallet-portis, hdwallet-metamask, and hdwallet-xdefi contain custom transports. These are not necessary, but that wasn't immediately obvious when they were created.

  • Remove PortisTransport, MetaMaskTransport, and XDeFiTransport.

Fixed by #422.
@mrnerdhair mrnerdhair added the tech-debt A suboptimality that existed in code when it was written. label Mar 14, 2022
@mrnerdhair mrnerdhair linked a pull request Mar 17, 2022 that will close this issue
remove unnecessary transports from portis & xdefi #422
Merged
@mrnerdhair mrnerdhair changed the title PortisTransport and XDeFiTransport are unnessecary PortisTransport, MetaMaskTransport, and XDeFiTransport are unnessecary Mar 23, 2022
@mrnerdhair mrnerdhair mentioned this issue Mar 23, 2022
Merged
@mrnerdhair mrnerdhair mentioned this issue Apr 1, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt A suboptimality that existed in code when it was written.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove unnecessary transports from portis & xdefi shapeshift/hdwallet
1 participant
@mrnerdhair