Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapely 2.0.2 micro release? #1852

Closed
mwtoews opened this issue Jul 11, 2023 · 10 comments
Closed

Shapely 2.0.2 micro release? #1852

mwtoews opened this issue Jul 11, 2023 · 10 comments
Labels
Milestone

Comments

@mwtoews
Copy link
Member

mwtoews commented Jul 11, 2023

A micro release from maint-2.0 could help resolve upstream GEOS 3.12 changes, e.g., see conda-forge/shapely-feedstock#125

However, I suggest the binary wheels stick to GEOS 3.11.x. I'll create a PR to bump the release to use GEOS 3.11.2. (not needed, it already is set to 3.11.2).

Here are the other pending changes: 2.0.1...maint-2.0

@mwtoews
Copy link
Member Author

mwtoews commented Jul 26, 2023

Pretty much the only blocking issue is #1670 which currently fail the test suite with the latest release of GEOS 3.12.0

Is #1708 suitable for inclusion for maint-2.0 / shapely 2.0.2?

@musicinmybrain
Copy link
Contributor

Pretty much the only blocking issue is #1670 which currently fail the test suite with the latest release of GEOS 3.12.0

This matches what I see when I try packaging a snapshot of the maint-2.0 branch, currently at eeb51ad, for Fedora Rawhide. The only remaining test failures I see are:

=========================== short test summary info ============================
FAILED tests/test_constructive.py::test_oriented_envelope[geometry0-expected0]
FAILED tests/test_constructive.py::test_oriented_envelope[geometry2-expected2]
FAILED tests/test_constructive.py::test_minimum_rotated_rectangle[geometry0-expected0]
FAILED tests/test_constructive.py::test_minimum_rotated_rectangle[geometry2-expected2]
============ 4 failed, 3462 passed, 27 skipped, 3 xfailed in 6.65s =============

@jorisvandenbossche
Copy link
Member

Yes, let's try to do a 2.0.2 release soon (there is also an older issue about this: #1742)

There are a few more things I would like to fix/backport, eg #1829 isn't yet backported.

Should we include #1872 (cython 3 compat). Since we properly pin cython right now, maybe not?

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Oct 8, 2023

I have a PR with a (final?) set of backports: #1904 (the eq regression, cython 3 fix, and linux aarch64 wheels update)

Then I will also make a PR with updating the release date etc (-> #1906)

@jorisvandenbossche
Copy link
Member

cc @shapely/shapely-team

@caspervdw
Copy link
Collaborator

I am 👍 on doing the release after #1904 is in.

@jorisvandenbossche
Copy link
Member

I would like to include #1708 (the minimum_rotated_rectangle change) as well, given that this fixes a change in 2.0.x compared to 1.8

@jorisvandenbossche
Copy link
Member

I am planning to release this evening, after merging #1708

@jorisvandenbossche
Copy link
Member

Released!

-> https://github.com/shapely/shapely/releases/tag/2.0.2
-> https://pypi.org/project/shapely/#files

@jorisvandenbossche
Copy link
Member

The stable docs confusingly show a version of "0", that's caused by a "bug" (well, at least a change) in readthedocs -> readthedocs/readthedocs.org#10715. But adding workaround in #1914

@jorisvandenbossche jorisvandenbossche added this to the 2.0.2 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants