Skip to content

Commit 967a37d

Browse files
committed
add params in unit tests
1 parent 1b1a9b8 commit 967a37d

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

cloudstack/resource_cloudstack_network_acl_rule_test.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,26 +245,31 @@ resource "cloudstack_network_acl_rule" "foo" {
245245
acl_id = cloudstack_network_acl.foo.id
246246
247247
rule {
248+
rule_number = 10
248249
action = "allow"
249250
cidr_list = ["172.18.100.0/24"]
250251
protocol = "all"
251252
traffic_type = "ingress"
253+
description = "Allow all traffic"
252254
}
253255
254256
rule {
257+
rule_number = 20
255258
action = "allow"
256259
cidr_list = ["172.18.100.0/24"]
257260
protocol = "icmp"
258261
icmp_type = "-1"
259262
icmp_code = "-1"
260263
traffic_type = "ingress"
264+
description = "Allow ICMP traffic"
261265
}
262266
263267
rule {
264268
cidr_list = ["172.16.100.0/24"]
265269
protocol = "tcp"
266270
ports = ["80", "443"]
267271
traffic_type = "ingress"
272+
description = "Allow HTTP and HTTPS"
268273
}
269274
}`
270275

@@ -293,27 +298,31 @@ resource "cloudstack_network_acl_rule" "foo" {
293298
}
294299
295300
rule {
301+
rule_number = 10
296302
action = "deny"
297-
cidr_list = ["172.18.100.0/24", "172.18.101.0/24"]
303+
cidr_list = ["172.18.100.0/24", "172.18.101.0/24"]
298304
protocol = "icmp"
299305
icmp_type = "-1"
300306
icmp_code = "-1"
301307
traffic_type = "ingress"
308+
description = "Deny ICMP traffic"
302309
}
303310
304311
rule {
305-
action = "allow"
312+
rule_number = 20
313+
action = "allow"
306314
cidr_list = ["172.18.100.0/24"]
307315
protocol = "tcp"
308316
ports = ["80", "443"]
309317
traffic_type = "ingress"
310318
}
311319
312320
rule {
313-
action = "deny"
321+
action = "deny"
314322
cidr_list = ["10.0.0.0/24"]
315323
protocol = "tcp"
316324
ports = ["80", "1000-2000"]
317325
traffic_type = "egress"
326+
description = "Deny specific TCP ports"
318327
}
319328
}`

0 commit comments

Comments
 (0)