fix lint

Author: Pearl1594

pkg/cloud/cloud.go

@@ -10,8 +10,8 @@ import (
 )
 
 // Interface is the CloudStack client interface.
-//
-//revive:disable:interfacebloat
+
+//nolint:interfacebloat
 type Interface interface {
 	GetNodeInfo(ctx context.Context, vmName string) (*VM, error)
 	GetVMByID(ctx context.Context, vmID string) (*VM, error)

pkg/cloud/fake/fake.go

@@ -204,23 +204,29 @@ func (f *fakeConnector) GetSnapshotByName(_ context.Context, name string) (*clou
 
 // ListSnapshots returns all matching snapshots; pagination must be handled by the controller.
 func (f *fakeConnector) ListSnapshots(_ context.Context, volumeID, snapshotID string) ([]*cloud.Snapshot, error) {
-	var result []*cloud.Snapshot
 	if snapshotID != "" {
+		result := make([]*cloud.Snapshot, 0, 1)
 		if snap, ok := f.snapshotsByID[snapshotID]; ok {
 			result = append(result, snap)
 		}
-
 		return result, nil
 	}
 	if volumeID != "" {
+		count := 0
+		for _, snap := range f.snapshotsByID {
+			if snap.VolumeID == volumeID {
+				count++
+			}
+		}
+		result := make([]*cloud.Snapshot, 0, count)
 		for _, snap := range f.snapshotsByID {
 			if snap.VolumeID == volumeID {
 				result = append(result, snap)
 			}
 		}
-
 		return result, nil
 	}
+	result := make([]*cloud.Snapshot, 0, len(f.snapshotsByID))
 	for _, snap := range f.snapshotsByID {
 		result = append(result, snap)
 	}
@@ -241,6 +247,7 @@ func (f *fakeConnector) DeleteSnapshot(_ context.Context, snapshotID string) err
 	for i, s := range snaps {
 		if s.ID == snapshotID {
 			f.snapshotsByName[name] = append(snaps[:i], snaps[i+1:]...)
+
 			break
 		}
 	}

pkg/cloud/snapshots.go

@@ -120,6 +120,7 @@ func (c *client) GetSnapshotByName(ctx context.Context, name string) (*Snapshot,
 		VolumeID:  snapshot.Volumeid,
 		CreatedAt: snapshot.Created,
 	}
+
 	return &s, nil
 }
 
@@ -147,7 +148,7 @@ func (c *client) ListSnapshots(ctx context.Context, volumeID, snapshotID string)
 	if l.Count == 0 {
 		return []*Snapshot{}, nil
 	}
-	var result []*Snapshot
+	result := make([]*Snapshot, 0, l.Count)
 	for _, snapshot := range l.Snapshots {
 		s := &Snapshot{
 			ID:        snapshot.Id,