Commit 5fcfc95
SAMZA-1990: Samza framework should let using the same system stream as both input and output.
**Symptom:** An `IllegalArgumentException` is thrown when the same `streamId` is referred from multiple input/output stream descriptors.
**Cause:** The `ApplicationDescriptorImpl` caches the serde instances for streams by a `streamId` and there's a check to ensure the expected stream serde matches when using the same stream from multiple input/output descriptors. However the check is incorrect because it compares serde instances and not serde types. This check always fails in this scenario.
**Fix:** Compare the stream serdes for a particular `streamId` by type.
Please take a look prateekm nickpan47
CC: atoomula
Author: Daniel Nishimura <dnishimura@linkedin.com>
Reviewers: prateekm
Closes apache#928 from dnishimura/samza-1990-same-stream-different-inputoutputdescriptors1 parent d5d0956 commit 5fcfc95
File tree
2 files changed
+5
-5
lines changed- samza-core/src/main/java/org/apache/samza/application/descriptors
- samza-test/src/test/java/org/apache/samza/test/samzasql
2 files changed
+5
-5
lines changedLines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
314 | | - | |
| 314 | + | |
| 315 | + | |
315 | 316 | | |
316 | 317 | | |
| 318 | + | |
| 319 | + | |
317 | 320 | | |
318 | 321 | | |
319 | 322 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
| 177 | + | |
181 | 178 | | |
182 | 179 | | |
183 | 180 | | |
| |||
0 commit comments