Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.2.5 #769

Merged
merged 12 commits into from
Feb 15, 2019
Merged

V3.2.5 #769

merged 12 commits into from
Feb 15, 2019

Conversation

shanalikhan
Copy link
Owner

No description provided.

MarvinJWendt and others added 11 commits December 18, 2018 19:09
*Total -- 20.98kb -> 13.27kb (36.77%)

/images/slack.png -- 13.83kb -> 8.04kb (41.9%)
/images/cloud.png -- 7.15kb -> 5.23kb (26.84%)
* Addapt test to changes.

* Get tabs or spaces and line breaks for each ignored line.

* Remove unnecesary tests

* New Approach for parsing pragmas

Instead of replacing entires blocks, we will loop each line in the settings file. For each line we are checking if should be ignored or if comments must be toggled. There is a block of code that is repeated to ensure the readability of the code.

* Support for Brackets and unifying repeated code

* Test for multi-line settings supporting curly braces and brackets. Changing test text extension.

* Remove unused function. Add new lines after ignored settings block.
Github -> GitHub
@shanalikhan shanalikhan added this to the v3.2.5 milestone Feb 13, 2019
@shanalikhan shanalikhan merged commit e80b2ce into master Feb 15, 2019
@shanalikhan shanalikhan deleted the v3.2.5 branch February 25, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants