Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifying client timeout #78

Closed
JosefWN opened this issue Apr 19, 2022 · 1 comment
Closed

Specifying client timeout #78

JosefWN opened this issue Apr 19, 2022 · 1 comment

Comments

@JosefWN
Copy link
Contributor

JosefWN commented Apr 19, 2022 •
edited
Loading

The client.timeout overrides the timeout implicitly specified by the config, should we allow this/do we need this? Initial discussion: #76 (comment)

I propose just dropping the client.timeout and letting the config dictate timeouts. Easier to manage in code and less confusing to the users of the library.
@JosefWN JosefWN mentioned this issue Apr 19, 2022
Merged
This was referenced May 1, 2022
Closed
Merged
@shamblett
Copy link
Owner

Package re released at version 4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shamblett @JosefWN