Skip to content

Commit c39b51d

Browse files
taglialagranowski
andauthored
Bump minimum required webpack version to 5.76.0 (#568)
This change addresses CVE-2023-28154 by requiring a non-affected version of webpack (5.76.0 or higher). While shakapacker itself is not directly impacted by this vulnerability, as webpack is a peer dependency and there are no constraints preventing developers from upgrading to a non-vulnerable version, this bump ensures a safer default. Note: The 5.99.x series was intentionally avoided due to its recent release and the risk of last-minute bugs, as evidenced by several patch upgrades in quick succession. Additionally, using 5.76.0 provides more stability and flexibility, including the ability to downgrade webpack if needed. Supersedes #564, Fix #567 References: - GHSA-hc6q-2mpp-qw7j test Co-authored-by: Derrick Granowski <granowski@gmail.com>
1 parent 157aef2 commit c39b51d

File tree

6 files changed

+3679
-4099
lines changed

6 files changed

+3679
-4099
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Changes since the last non-beta release.
1515
### Changed
1616

1717
- Instead of a fixed `core-js` version, take the current one from `node_modules` if available. [PR 556](https://github.com/shakacode/shakapacker/pull/556) by [alexeyr-ci2](https://github.com/alexeyr-ci2).
18+
- Require webpack >= 5.76.0 to reduce exposure to CVE-2023-28154. [PR 568](https://github.com/shakacode/shakapacker/pull/568) by [granowski](https://github.com/granowski).
1819

1920
### Fixed
2021

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,18 +33,18 @@
3333
"eslint": "^8.0.0",
3434
"eslint-config-airbnb": "^19.0.0",
3535
"eslint-config-prettier": "^9.0.0",
36-
"eslint-plugin-import": "^2.24.2",
36+
"eslint-plugin-import": "^2.31.0",
3737
"eslint-plugin-jest": "^27.9.0",
38-
"eslint-plugin-jsx-a11y": "^6.4.1",
39-
"eslint-plugin-prettier": "^5.1.3",
40-
"eslint-plugin-react": "^7.26.0",
38+
"eslint-plugin-jsx-a11y": "^6.10.2",
39+
"eslint-plugin-prettier": "^5.2.6",
40+
"eslint-plugin-react": "^7.37.5",
4141
"eslint-plugin-react-hooks": "^4.6.0",
42-
"jest": "^28.1.3",
42+
"jest": "^29.7.0",
4343
"memory-fs": "^0.5.0",
4444
"prettier": "^3.2.5",
4545
"swc-loader": "^0.1.15",
4646
"thenify": "^3.3.1",
47-
"webpack": "^5.72.0",
47+
"webpack": "5.93.0",
4848
"webpack-assets-manifest": "^5.0.6",
4949
"webpack-merge": "^5.8.0"
5050
},
@@ -58,7 +58,7 @@
5858
"babel-loader": "^8.2.4 || ^9.0.0 || ^10.0.0",
5959
"compression-webpack-plugin": "^9.0.0 || ^10.0.0|| ^11.0.0",
6060
"terser-webpack-plugin": "^5.3.1",
61-
"webpack": "^5.72.0",
61+
"webpack": "^5.76.0",
6262
"webpack-assets-manifest": "^5.0.6 || ^6.0.0",
6363
"webpack-cli": "^4.9.2 || ^5.0.0 || ^6.0.0",
6464
"webpack-dev-server": "^4.9.0 || ^5.0.0",

spec/dummy/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"style-loader": "^3.3.1",
2929
"terser-webpack-plugin": "^5.3.3",
3030
"typescript": "^4.7.3",
31-
"webpack": "^5.73.0",
31+
"webpack": "^5.76.0",
3232
"webpack-assets-manifest": "^5.1.0",
3333
"webpack-cli": "^4.9.2",
3434
"webpack-merge": "^5.8.0",

0 commit comments

Comments
 (0)