fix: Clean up error messages and update CHANGELOG

Address code review feedback:

- Update CHANGELOG.md placeholder with PR #2051
- Simplify error warning messages - remove misleading comments about
  shakapacker dependency since failures can occur for multiple reasons
  (network errors, permissions, etc.)
- Remove redundant puts statement in add_package rescue block since
  calling methods already add appropriate warnings

These changes improve code clarity and user-facing error messages.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: justin808

CHANGELOG.md

@@ -57,7 +57,7 @@ Changes since the last non-beta release.
 
 - **Generator Configuration Modernization**: Updated the generator to enable recommended configurations by default for new applications. `config.build_test_command` is now uncommented and set to `"RAILS_ENV=test bin/shakapacker"` by default, enabling automatic asset building during tests for better integration test reliability. `config.auto_load_bundle = true` is now set by default, enabling automatic loading of component bundles. `config.components_subdirectory = "ror_components"` is now set by default, organizing React components in a dedicated subdirectory. **Note:** These changes only affect newly generated applications. Existing applications are unaffected and do not need to make any changes. If you want to adopt these settings in an existing app, you can manually add them to your `config/initializers/react_on_rails.rb` file. [PR 2039](https://github.com/shakacode/react_on_rails/pull/2039) by [justin808](https://github.com/justin808).
 
-- **Removed Babel Dependency Installation**: The generator no longer installs `@babel/preset-react` or `@babel/preset-typescript` packages. Shakapacker handles JavaScript transpiler configuration (Babel, SWC, or esbuild) via the `javascript_transpiler` setting in `shakapacker.yml`. SWC is now the default transpiler and includes built-in support for React and TypeScript. Users who explicitly choose Babel will need to manually install and configure the required presets. This change reduces unnecessary dependencies and aligns with Shakapacker's modular transpiler approach. [PR <PLACEHOLDER>](https://github.com/shakacode/react_on_rails/pull/<PLACEHOLDER>) by [justin808](https://github.com/justin808).
+- **Removed Babel Dependency Installation**: The generator no longer installs `@babel/preset-react` or `@babel/preset-typescript` packages. Shakapacker handles JavaScript transpiler configuration (Babel, SWC, or esbuild) via the `javascript_transpiler` setting in `shakapacker.yml`. SWC is now the default transpiler and includes built-in support for React and TypeScript. Users who explicitly choose Babel will need to manually install and configure the required presets. This change reduces unnecessary dependencies and aligns with Shakapacker's modular transpiler approach. [PR 2051](https://github.com/shakacode/react_on_rails/pull/2051) by [justin808](https://github.com/justin808).
 
 #### Documentation
 

lib/generators/react_on_rails/js_dependency_manager.rb

@@ -132,11 +132,9 @@ def add_react_on_rails_package
         puts "Installing React on Rails package..."
         return if add_package(react_on_rails_pkg)
 
-        # This should not happen since package_json is always available via shakapacker
         GeneratorMessages.add_warning(<<~MSG.strip)
-          ⚠️  Failed to add react-on-rails package via package_json gem.
+          ⚠️  Failed to add react-on-rails package.
 
-          This indicates shakapacker dependency may not be properly installed.
           You can install it manually by running:
             npm install #{react_on_rails_pkg}
         MSG
@@ -153,11 +151,9 @@ def add_react_dependencies
         puts "Installing React dependencies..."
         return if add_packages(REACT_DEPENDENCIES)
 
-        # This should not happen since package_json is always available via shakapacker
         GeneratorMessages.add_warning(<<~MSG.strip)
-          ⚠️  Failed to add React dependencies via package_json gem.
+          ⚠️  Failed to add React dependencies.
 
-          This indicates shakapacker dependency may not be properly installed.
           You can install them manually by running:
             npm install #{REACT_DEPENDENCIES.join(' ')}
         MSG
@@ -174,11 +170,9 @@ def add_css_dependencies
         puts "Installing CSS handling dependencies..."
         return if add_packages(CSS_DEPENDENCIES)
 
-        # This should not happen since package_json is always available via shakapacker
         GeneratorMessages.add_warning(<<~MSG.strip)
-          ⚠️  Failed to add CSS dependencies via package_json gem.
+          ⚠️  Failed to add CSS dependencies.
 
-          This indicates shakapacker dependency may not be properly installed.
           You can install them manually by running:
             npm install #{CSS_DEPENDENCIES.join(' ')}
         MSG
@@ -195,11 +189,9 @@ def add_rspack_dependencies
         puts "Installing Rspack core dependencies..."
         return if add_packages(RSPACK_DEPENDENCIES)
 
-        # This should not happen since package_json is always available via shakapacker
         GeneratorMessages.add_warning(<<~MSG.strip)
-          ⚠️  Failed to add Rspack dependencies via package_json gem.
+          ⚠️  Failed to add Rspack dependencies.
 
-          This indicates shakapacker dependency may not be properly installed.
           You can install them manually by running:
             npm install #{RSPACK_DEPENDENCIES.join(' ')}
         MSG
@@ -216,11 +208,9 @@ def add_typescript_dependencies
         puts "Installing TypeScript dependencies..."
         return if add_packages(TYPESCRIPT_DEPENDENCIES, dev: true)
 
-        # This should not happen since package_json is always available via shakapacker
         GeneratorMessages.add_warning(<<~MSG.strip)
-          ⚠️  Failed to add TypeScript dependencies via package_json gem.
+          ⚠️  Failed to add TypeScript dependencies.
 
-          This indicates shakapacker dependency may not be properly installed.
           You can install them manually by running:
             npm install --save-dev #{TYPESCRIPT_DEPENDENCIES.join(' ')}
         MSG
@@ -245,11 +235,9 @@ def add_dev_dependencies
 
         return if add_packages(dev_deps, dev: true)
 
-        # This should not happen since package_json is always available via shakapacker
         GeneratorMessages.add_warning(<<~MSG.strip)
-          ⚠️  Failed to add development dependencies via package_json gem.
+          ⚠️  Failed to add development dependencies.
 
-          This indicates shakapacker dependency may not be properly installed.
           You can install them manually by running:
             npm install --save-dev #{dev_deps.join(' ')}
         MSG
@@ -284,8 +272,8 @@ def add_package(package, dev: false)
             pj.manager.add(packages_array, exact: true)
           end
           true
-        rescue StandardError => e
-          puts "Warning: Could not add #{package} via package_json gem: #{e.message}"
+        rescue StandardError
+          # Return false to trigger warning in calling method
           false
         end
       end