Skip to content

Commit aac522b

Browse files
committed
Remove js-yaml peer dependency and mentions of removed webpackConfigLoader
1 parent fc789d9 commit aac522b

File tree

5 files changed

+5
-4
lines changed

5 files changed

+5
-4
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ Please follow the recommendations outlined at [keepachangelog.com](http://keepac
1818
### [Unreleased]
1919
Changes since the last non-beta release.
2020

21+
#### Fixed
22+
- Removed obsolete `js-yaml` peer dependency. [PR 1678](https://github.com/shakacode/react_on_rails/pull/1678) by [alexeyr-ci](https://github.com/alexeyr-ci).
23+
2124
### [14.1.0] - 2025-01-06
2225

2326
#### Fixed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: .
33
specs:
4-
react_on_rails (15.0.0.alpha.1)
4+
react_on_rails (14.1.0)
55
addressable
66
connection_pool
77
execjs (~> 2.5)

docs/additional-details/manual-installation-overview.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ The only requirements within this directory for basic React on Rails integration
1717
1. Your JavaScript code "registers" any components and stores per the ReactOnRails APIs of ReactOnRails.register(components) and ReactOnRails.registerStore(stores). See [our javascript API docs](https://www.shakacode.com/react-on-rails/docs/api/javascript-api/) and the [ReactOnRails.js source](https://github.com/shakacode/react_on_rails/tree/master/node_package/src/ReactOnRails.js).
1818
1. Set your registration file as an "entry" point in your Webpack configs.
1919
1. Add the [Manifest plugin](https://github.com/danethurber/webpack-manifest-plugin) to your config.
20-
The default path: `public/webpack` can be loaded with webpackConfigLoader as shown in the dummy example.
2120
1. You create scripts in `client/package.json` per the example apps. These are used for building your Webpack assets. Also do this for your top level `package.json`.
2221

2322
## Rails Steps (outside of /client)

docs/guides/webpack-configuration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ You can access values in the `config/shakapacker.yml`
3636
const { config, devServer } = require('shakapacker');
3737
```
3838

39-
You will want consider using some of the same values set in these files:
39+
You will want to consider using some of the same values set in these files:
4040

4141
* https://github.com/shakacode/shakapacker/blob/master/package/environments/base.js
4242
* https://github.com/shakacode/shakapacker/blob/master/package/environments/development.js

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
"@babel/runtime-corejs3": "^7.12.5"
5151
},
5252
"peerDependencies": {
53-
"js-yaml": ">= 3.0.0",
5453
"react": ">= 16",
5554
"react-dom": ">= 16"
5655
},

0 commit comments

Comments
 (0)