Remove semver_to_string

Author: alexeyr

lib/react_on_rails/configuration.rb

@@ -180,7 +180,7 @@ def validate_generated_component_packs_loading_strategy
         1. Use :sync or :defer loading strategy instead of :async
         2. Upgrade to Shakapacker v8.2.0 or above to enable async script loading
       MSG
-      if PackerUtils.shakapacker_version_requirement_met?([8, 2, 0])
+      if PackerUtils.shakapacker_version_requirement_met?("8.2.0")
         self.generated_component_packs_loading_strategy ||= :async
       elsif generated_component_packs_loading_strategy.nil?
         Rails.logger.warn("**WARNING** #{msg}")

lib/react_on_rails/packer_utils.rb

@@ -10,7 +10,7 @@ def self.using_shakapacker_const?
       return @using_shakapacker_const if defined?(@using_shakapacker_const)
 
       @using_shakapacker_const = ReactOnRails::Utils.gem_available?("shakapacker") &&
-                                 shakapacker_version_requirement_met?([7, 0, 0])
+                                 shakapacker_version_requirement_met?("7.0.0")
     end
 
     def self.using_webpacker_const?
@@ -64,9 +64,7 @@ def self.shakapacker_version_as_array
     end
 
     def self.shakapacker_version_requirement_met?(required_version)
-      req_ver = semver_to_string(required_version)
-
-      Gem::Version.new(shakapacker_version) >= Gem::Version.new(req_ver)
+      Gem::Version.new(shakapacker_version) >= Gem::Version.new(required_version)
     end
 
     # This returns either a URL for the webpack-dev-server, non-server bundle or
@@ -172,7 +170,7 @@ def self.raise_nested_entries_disabled
 
     def self.raise_shakapacker_version_incompatible_for_autobundling
       msg = <<~MSG
-        **ERROR** ReactOnRails: Please upgrade Shakapacker to version #{semver_to_string(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION)} or \
+        **ERROR** ReactOnRails: Please upgrade Shakapacker to version #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION} or \
         above to use the automated bundle generation feature. The currently installed version is \
         #{ReactOnRails::PackerUtils.shakapacker_version}.
       MSG
@@ -183,15 +181,11 @@ def self.raise_shakapacker_version_incompatible_for_autobundling
     def self.raise_shakapacker_not_installed
       msg = <<~MSG
         **ERROR** ReactOnRails: Missing Shakapacker gem. Please upgrade to use Shakapacker \
-        #{semver_to_string(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION)} or above to use the \
+        #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION} or above to use the \
         automated bundle generation feature.
       MSG
 
       raise ReactOnRails::Error, msg
     end
-
-    def self.semver_to_string(ary)
-      ary.join(".")
-    end
   end
 end

lib/react_on_rails/packs_generator.rb

@@ -6,7 +6,7 @@ module ReactOnRails
   # rubocop:disable Metrics/ClassLength
   class PacksGenerator
     CONTAINS_CLIENT_OR_SERVER_REGEX = /\.(server|client)($|\.)/
-    MINIMUM_SHAKAPACKER_VERSION = [6, 5, 1].freeze
+    MINIMUM_SHAKAPACKER_VERSION = "6.5.1"
 
     def self.instance
       @instance ||= PacksGenerator.new

spec/react_on_rails/configuration_spec.rb

@@ -379,7 +379,7 @@ module ReactOnRails
       context "when using Shakapacker >= 8.2.0" do
         before do
           allow(ReactOnRails::PackerUtils).to receive(:shakapacker_version_requirement_met?)
-            .with([8, 2, 0]).and_return(true)
+            .with("8.2.0").and_return(true)
         end
 
         it "defaults to :async" do
@@ -426,7 +426,7 @@ module ReactOnRails
       context "when using Shakapacker < 8.2.0" do
         before do
           allow(ReactOnRails::PackerUtils).to receive(:shakapacker_version_requirement_met?)
-            .with([8, 2, 0]).and_return(false)
+            .with("8.2.0").and_return(false)
           allow(Rails.logger).to receive(:warn)
         end
 

spec/react_on_rails/packer_utils_spec.rb

@@ -5,7 +5,7 @@
 module ReactOnRails
   describe PackerUtils do
     describe ".shakapacker_version_requirement_met?" do
-      minimum_version = [6, 5, 3]
+      minimum_version = "6.5.3"
 
       it "returns false when version is lower than minimum_version" do
         allow(described_class).to receive(:shakapacker_version).and_return("6.5.0")
@@ -31,7 +31,7 @@ module ReactOnRails
         allow(described_class).to receive(:shakapacker_version).and_return("6.5.4")
         expect(described_class.shakapacker_version_requirement_met?(minimum_version)).to be(true)
 
-        allow(described_class).to receive(:shakapacker_version).and_return("7.7.7")
+        allow(described_class).to receive(:shakapacker_version).and_return("7.0.0")
         expect(described_class.shakapacker_version_requirement_met?(minimum_version)).to be(true)
       end
     end