Skip to content

Commit 6697543

Browse files
committed
Try to remove unused spec/dummy dependencies
1 parent 8a91488 commit 6697543

File tree

5 files changed

+771
-873
lines changed

5 files changed

+771
-873
lines changed

knip.ts

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,21 @@ const config: KnipConfig = {
5454
'@rescript/react',
5555
// The Babel plugin fails to detect it
5656
'babel-plugin-transform-react-remove-prop-types',
57-
// Temporary!
58-
'.*',
57+
// This one is weird. It's long-deprecated and shouldn't be necessary.
58+
// Probably need to update the Webpack config.
59+
'node-libs-browser',
60+
// The below dependencies are not detected by the Webpack plugin
61+
// due to the config issue.
62+
'css-loader',
63+
'expose-loader',
64+
'file-loader',
65+
'imports-loader',
66+
'null-loader',
67+
'sass',
68+
'sass-loader',
69+
'sass-resources-loader',
70+
'style-loader',
71+
'url-loader',
5972
],
6073
},
6174
},

spec/dummy/config/webpack/commonWebpackConfig.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const sassLoaderConfig = {
2424
const scssConfigIndex = baseClientWebpackConfig.module.rules.findIndex((config) =>
2525
'.scss'.match(config.test),
2626
);
27-
baseClientWebpackConfig.module.rules[scssConfigIndex].use.push(sassLoaderConfig);
27+
baseClientWebpackConfig.module.rules[scssConfigIndex]?.use.push(sassLoaderConfig);
2828

2929
// add jquery
3030
const exposeJQuery = {

spec/dummy/package.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,16 @@
1515
"@hotwired/turbo-rails": "^8.0.4",
1616
"@rescript/react": "^0.13.0",
1717
"babel-loader": "8.2.4",
18-
"babel-plugin-macros": "^3.1.0",
19-
"babel-plugin-module-resolver": "^4.0.0",
2018
"babel-plugin-transform-react-remove-prop-types": "^0.4.24",
2119
"compression-webpack-plugin": "9",
2220
"core-js": "3",
2321
"create-react-class": "^15.6.3",
2422
"css-loader": "^6.5.1",
25-
"css-minimizer-webpack-plugin": "^3.1.3",
2623
"expose-loader": "^1.0.3",
2724
"file-loader": "^6.2.0",
28-
"history": "^4.6.3",
2925
"imports-loader": "^1.2.0",
3026
"jquery": "^3.5.1",
3127
"jquery-ujs": "^1.2.2",
32-
"loader-utils": "^2.0.0",
3328
"lodash": "^4.17.4",
3429
"mini-css-extract-plugin": "^2.4.4",
3530
"node-libs-browser": "^2.2.1",
@@ -46,7 +41,6 @@
4641
"redux-thunk": "^2.2.0",
4742
"regenerator-runtime": "^0.13.4",
4843
"rescript": "^11.1.4",
49-
"resolve-url-loader": "^3.1.1",
5044
"sass": "^1.43.4",
5145
"sass-loader": "^12.3.0",
5246
"sass-resources-loader": "^2.1.0",

0 commit comments

Comments
 (0)