Eliminate duplicate defaults in benchmark.yml

Author: alexeyr

.github/workflows/benchmark.yml

@@ -1,5 +1,27 @@
 name: Benchmark Workflow
 
+env:
+  FORTIO_VERSION: "1.73.0"
+  K6_VERSION: "1.3.0"
+  VEGETA_VERSION: "12.13.0"
+  # Benchmark parameters
+  DEFAULT_RATE: &default_rate 'max'
+  DEFAULT_DURATION_SEC: &default_duration_sec 30
+  DEFAULT_REQUEST_TIMEOUT: &default_request_timeout '60s'
+  DEFAULT_CONNECTIONS: &default_connections 10
+  DEFAULT_WEB_CONCURRENCY: &default_web_concurrency 4
+  DEFAULT_RAILS_THREADS: &default_rails_threads 3
+  DEFAULT_TOOLS: &default_tools 'fortio,vegeta,k6'
+  RATE: ${{ github.event.inputs.rate || env.DEFAULT_RATE }}
+  DURATION_SEC: ${{ github.event.inputs.duration_sec || env.DEFAULT_DURATION_SEC }}
+  REQUEST_TIMEOUT: ${{ github.event.inputs.request_timeout || env.DEFAULT_REQUEST_TIMEOUT }}
+  CONNECTIONS: ${{ github.event.inputs.connections || env.DEFAULT_CONNECTIONS }}
+  MAX_CONNECTIONS: ${{ github.event.inputs.max_connections || github.event.inputs.connections || env.DEFAULT_CONNECTIONS }}
+  WEB_CONCURRENCY: ${{ github.event.inputs.web_concurrency || env.DEFAULT_WEB_CONCURRENCY }}
+  RAILS_MAX_THREADS: ${{ github.event.inputs.rails_max_threads || env.DEFAULT_RAILS_THREADS }}
+  RAILS_MIN_THREADS: ${{ github.event.inputs.rails_min_threads || github.event.inputs.rails_max_threads || env.DEFAULT_RAILS_THREADS }}
+  TOOLS: ${{ github.event.inputs.tools || env.DEFAULT_TOOLS }}
+
 on:
   # https://github.com/mxschmitt/action-tmate?tab=readme-ov-file#manually-triggered-debug
   workflow_dispatch:
@@ -12,22 +34,22 @@ on:
       rate:
         description: 'Requests per second (use "max" for maximum throughput)'
         required: false
-        default: 'max'
+        default: *default_rate
         type: string
       duration_sec:
         description: 'Duration in seconds'
         required: false
-        default: 30
+        default: *default_duration_sec
         type: number
       request_timeout:
         description: 'Request timeout (e.g., "60s", "1m", "90s")'
         required: false
-        default: '60s'
+        default: *default_request_timeout
         type: string
       connections:
         description: 'Concurrent connections/virtual users'
         required: false
-        default: 10
+        default: *default_connections
         type: number
       max_connections:
         description: 'Maximum connections/virtual users'
@@ -36,12 +58,12 @@ on:
       web_concurrency:
         description: 'Number of Puma worker processes'
         required: false
-        default: 4
+        default: *default_web_concurrency
         type: number
       rails_max_threads:
         description: 'Maximum number of Puma threads'
         required: false
-        default: 3
+        default: *default_rails_threads
         type: number
       rails_min_threads:
         description: 'Minimum number of Puma threads (same as maximum if not set)'
@@ -50,28 +72,13 @@ on:
       tools:
         description: 'Comma-separated list of tools to run'
         required: false
-        default: 'fortio,vegeta,k6'
+        default: *default_tools
         type: string
   push:
     branches:
       - master
   pull_request:
 
-env:
-  FORTIO_VERSION: "1.73.0"
-  K6_VERSION: "1.3.0"
-  VEGETA_VERSION: "12.13.0"
-  # Benchmark parameters
-  RATE: ${{ github.event.inputs.rate || 'max' }}
-  DURATION_SEC: ${{ github.event.inputs.duration_sec || '30' }}
-  REQUEST_TIMEOUT: ${{ github.event.inputs.request_timeout || '60s' }}
-  CONNECTIONS: ${{ github.event.inputs.connections || '10' }}
-  MAX_CONNECTIONS: ${{ github.event.inputs.max_connections || github.event.inputs.connections || '10' }}
-  WEB_CONCURRENCY: ${{ github.event.inputs.web_concurrency || '4' }}
-  RAILS_MAX_THREADS: ${{ github.event.inputs.rails_max_threads || '3' }}
-  RAILS_MIN_THREADS: ${{ github.event.inputs.rails_min_threads || github.event.inputs.rails_max_threads || '3' }}
-  TOOLS: ${{ github.event.inputs.tools || 'fortio,vegeta,k6' }}
-
 jobs:
   benchmark:
     runs-on: ubuntu-latest