Address CodeRabbit review comments

Fix duplicate dependency installations:
- Track package_json vs direct install usage to prevent duplicate installs
- Only run bulk install when package_json was used and no direct installs occurred
- Avoids multiple npm install commands for the same dependencies

Fix GeneratorMessages handling:
- Remove GeneratorMessages.output.clear to preserve important warnings/errors
- Redux generator now appends messages instead of clearing previous ones
- Prevents loss of Shakapacker warnings and other installation messages

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: ihabadham

lib/generators/react_on_rails/install_generator.rb

@@ -83,8 +83,10 @@ def invoke_generators
       end
 
       def setup_react_dependencies
+        @added_dependencies_to_package_json ||= false
+        @ran_direct_installs ||= false
         add_js_dependencies
-        install_js_dependencies
+        install_js_dependencies if @added_dependencies_to_package_json && !@ran_direct_installs
       end
 
       # NOTE: other requirements for existing files such as .gitignore or application.
@@ -438,10 +440,14 @@ def add_react_on_rails_package
                              end
 
         puts "Installing React on Rails package..."
-        return if add_npm_dependencies(react_on_rails_pkg)
+        if add_npm_dependencies(react_on_rails_pkg)
+          @added_dependencies_to_package_json = true
+          return
+        end
 
         puts "Using direct npm commands as fallback"
         success = system("npm", "install", *react_on_rails_pkg)
+        @ran_direct_installs = true if success
         handle_npm_failure("react-on-rails package", react_on_rails_pkg) unless success
       end
 
@@ -455,9 +461,13 @@ def add_react_dependencies
           babel-plugin-transform-react-remove-prop-types
           babel-plugin-macros
         ]
-        return if add_npm_dependencies(react_deps)
+        if add_npm_dependencies(react_deps)
+          @added_dependencies_to_package_json = true
+          return
+        end
 
         success = system("npm", "install", *react_deps)
+        @ran_direct_installs = true if success
         handle_npm_failure("React dependencies", react_deps) unless success
       end
 
@@ -469,9 +479,13 @@ def add_css_dependencies
           mini-css-extract-plugin
           style-loader
         ]
-        return if add_npm_dependencies(css_deps)
+        if add_npm_dependencies(css_deps)
+          @added_dependencies_to_package_json = true
+          return
+        end
 
         success = system("npm", "install", *css_deps)
+        @ran_direct_installs = true if success
         handle_npm_failure("CSS dependencies", css_deps) unless success
       end
 
@@ -481,9 +495,13 @@ def add_dev_dependencies
           @pmmmwh/react-refresh-webpack-plugin
           react-refresh
         ]
-        return if add_npm_dependencies(dev_deps, dev: true)
+        if add_npm_dependencies(dev_deps, dev: true)
+          @added_dependencies_to_package_json = true
+          return
+        end
 
         success = system("npm", "install", "--save-dev", *dev_deps)
+        @ran_direct_installs = true if success
         handle_npm_failure("development dependencies", dev_deps, dev: true) unless success
       end
 

lib/generators/react_on_rails/react_with_redux_generator.rb

@@ -90,8 +90,7 @@ def add_redux_npm_dependencies
       end
 
       def add_redux_specific_messages
-        # Override the generic messages with Redux-specific instructions
-        GeneratorMessages.output.clear
+        # Append Redux-specific post-install instructions
         GeneratorMessages.add_info(
           GeneratorMessages.helpful_message_after_installation(component_name: "HelloWorldApp", route: "hello_world")
         )