Skip to content

Commit 43919ad

Browse files
justin808claude
andcommitted
Add TODO comments to track cache re-enabling for Node.js 22
Added TODO comments in all affected workflow files to ensure we remember to re-enable yarn cache once the Node.js 22 V8 bug is fixed. This provides a clear path for future cleanup when the upstream bug at nodejs/node#56010 is resolved. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent c346a43 commit 43919ad

File tree

5 files changed

+16
-8
lines changed

5 files changed

+16
-8
lines changed

.github/workflows/lint-js-and-ruby.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,9 @@ jobs:
5555
uses: actions/setup-node@v4
5656
with:
5757
node-version: 22
58+
# TODO: Re-enable cache when Node.js 22 V8 bug is fixed
5859
# Disable cache for Node 22 due to V8 bug in 22.21.0
59-
# https://github.com/nodejs/node/issues/56010
60+
# Track: https://github.com/nodejs/node/issues/56010
6061
cache: ''
6162
cache-dependency-path: '**/yarn.lock'
6263
- name: Print system information

.github/workflows/package-js-tests.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,9 @@ jobs:
6060
uses: actions/setup-node@v4
6161
with:
6262
node-version: ${{ matrix.node-version }}
63+
# TODO: Re-enable cache when Node.js 22 V8 bug is fixed
6364
# Disable cache for Node 22 due to V8 bug in 22.21.0
64-
# https://github.com/nodejs/node/issues/56010
65+
# Track: https://github.com/nodejs/node/issues/56010
6566
cache: ${{ matrix.node-version != '22' && 'yarn' || '' }}
6667
cache-dependency-path: '**/yarn.lock'
6768
- name: Print system information

.github/workflows/pro-integration-tests.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,9 @@ jobs:
5252
uses: actions/setup-node@v4
5353
with:
5454
node-version: 22
55+
# TODO: Re-enable cache when Node.js 22 V8 bug is fixed
5556
# Disable cache for Node 22 due to V8 bug in 22.21.0
56-
# https://github.com/nodejs/node/issues/56010
57+
# Track: https://github.com/nodejs/node/issues/56010
5758
cache: ''
5859
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
5960

@@ -141,8 +142,9 @@ jobs:
141142
uses: actions/setup-node@v4
142143
with:
143144
node-version: 22
145+
# TODO: Re-enable cache when Node.js 22 V8 bug is fixed
144146
# Disable cache for Node 22 due to V8 bug in 22.21.0
145-
# https://github.com/nodejs/node/issues/56010
147+
# Track: https://github.com/nodejs/node/issues/56010
146148
cache: ''
147149
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
148150

@@ -331,8 +333,9 @@ jobs:
331333
uses: actions/setup-node@v4
332334
with:
333335
node-version: 22
336+
# TODO: Re-enable cache when Node.js 22 V8 bug is fixed
334337
# Disable cache for Node 22 due to V8 bug in 22.21.0
335-
# https://github.com/nodejs/node/issues/56010
338+
# Track: https://github.com/nodejs/node/issues/56010
336339
cache: ''
337340
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
338341

.github/workflows/pro-lint.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,9 @@ jobs:
5151
uses: actions/setup-node@v4
5252
with:
5353
node-version: 22
54+
# TODO: Re-enable cache when Node.js 22 V8 bug is fixed
5455
# Disable cache for Node 22 due to V8 bug in 22.21.0
55-
# https://github.com/nodejs/node/issues/56010
56+
# Track: https://github.com/nodejs/node/issues/56010
5657
cache: ''
5758
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
5859

.github/workflows/pro-package-tests.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,9 @@ jobs:
5252
uses: actions/setup-node@v4
5353
with:
5454
node-version: 22
55+
# TODO: Re-enable cache when Node.js 22 V8 bug is fixed
5556
# Disable cache for Node 22 due to V8 bug in 22.21.0
56-
# https://github.com/nodejs/node/issues/56010
57+
# Track: https://github.com/nodejs/node/issues/56010
5758
cache: ''
5859
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
5960

@@ -146,8 +147,9 @@ jobs:
146147
uses: actions/setup-node@v4
147148
with:
148149
node-version: 22
150+
# TODO: Re-enable cache when Node.js 22 V8 bug is fixed
149151
# Disable cache for Node 22 due to V8 bug in 22.21.0
150-
# https://github.com/nodejs/node/issues/56010
152+
# Track: https://github.com/nodejs/node/issues/56010
151153
cache: ''
152154
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
153155

0 commit comments

Comments
 (0)