Skip to content

Commit 4291617

Browse files
committed
Try to remove unused spec/dummy dependencies
1 parent 5765b58 commit 4291617

File tree

4 files changed

+40
-780
lines changed

4 files changed

+40
-780
lines changed

knip.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,11 @@ const config: KnipConfig = {
5454
'@rescript/react',
5555
// The Babel plugin fails to detect it
5656
'babel-plugin-transform-react-remove-prop-types',
57-
// Temporary!
58-
'.*',
57+
// The below dependencies are not detected by the Webpack plugin
58+
// due to the config issue.
59+
'expose-loader',
60+
'imports-loader',
61+
'sass-resources-loader',
5962
],
6063
},
6164
},

spec/dummy/config/webpack/commonWebpackConfig.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const sassLoaderConfig = {
2424
const scssConfigIndex = baseClientWebpackConfig.module.rules.findIndex((config) =>
2525
'.scss'.match(config.test),
2626
);
27-
baseClientWebpackConfig.module.rules[scssConfigIndex].use.push(sassLoaderConfig);
27+
baseClientWebpackConfig.module.rules[scssConfigIndex]?.use.push(sassLoaderConfig);
2828

2929
// add jquery
3030
const exposeJQuery = {

spec/dummy/package.json

Lines changed: 21 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -7,34 +7,15 @@
77
},
88
"private": true,
99
"dependencies": {
10-
"@babel/core": "7.17.9",
11-
"@babel/plugin-transform-runtime": "7.17.0",
12-
"@babel/preset-env": "7",
13-
"@babel/preset-react": "^7.10.4",
1410
"@babel/runtime": "7.17.9",
1511
"@hotwired/turbo-rails": "^8.0.4",
16-
"@rescript/react": "^0.13.0",
17-
"babel-loader": "8.2.4",
18-
"babel-plugin-macros": "^3.1.0",
19-
"babel-plugin-module-resolver": "^4.0.0",
20-
"babel-plugin-transform-react-remove-prop-types": "^0.4.24",
21-
"compression-webpack-plugin": "9",
2212
"core-js": "3",
2313
"create-react-class": "^15.6.3",
24-
"css-loader": "^6.5.1",
25-
"css-minimizer-webpack-plugin": "^3.1.3",
2614
"expose-loader": "^1.0.3",
27-
"file-loader": "^6.2.0",
28-
"history": "^4.6.3",
2915
"imports-loader": "^1.2.0",
3016
"jquery": "^3.5.1",
3117
"jquery-ujs": "^1.2.2",
32-
"loader-utils": "^2.0.0",
3318
"lodash": "^4.17.4",
34-
"mini-css-extract-plugin": "^2.4.4",
35-
"node-libs-browser": "^2.2.1",
36-
"nps": "^5.10.0",
37-
"null-loader": "^4.0.0",
3819
"prop-types": "^15.7.2",
3920
"react": "^19.0.0",
4021
"react-dom": "^19.0.0",
@@ -46,25 +27,40 @@
4627
"redux-thunk": "^2.2.0",
4728
"regenerator-runtime": "^0.13.4",
4829
"rescript": "^11.1.4",
49-
"resolve-url-loader": "^3.1.1",
50-
"sass": "^1.43.4",
51-
"sass-loader": "^12.3.0",
52-
"sass-resources-loader": "^2.1.0",
5330
"shakapacker": "8.0.0",
54-
"style-loader": "^3.3.1",
5531
"terser-webpack-plugin": "5.3.1",
56-
"url-loader": "^4.0.0",
5732
"webpack": "5.72.0",
5833
"webpack-assets-manifest": "5",
5934
"webpack-cli": "4",
6035
"webpack-merge": "5"
6136
},
6237
"devDependencies": {
38+
"@babel/core": "7.17.9",
39+
"@babel/plugin-transform-runtime": "7.17.0",
40+
"@babel/preset-env": "7",
41+
"@babel/preset-react": "^7.10.4",
6342
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.1",
43+
"@rescript/react": "^0.13.0",
6444
"@types/react": "^19.0.0",
6545
"@types/react-dom": "^19.0.0",
6646
"@types/react-helmet": "^6.1.5",
47+
"babel-loader": "8.2.4",
48+
"babel-plugin-macros": "^3.1.0",
49+
"babel-plugin-module-resolver": "^4.0.0",
50+
"babel-plugin-transform-react-remove-prop-types": "^0.4.24",
51+
"compression-webpack-plugin": "9",
52+
"css-loader": "^6.5.1",
53+
"css-minimizer-webpack-plugin": "^3.1.3",
54+
"file-loader": "^6.2.0",
55+
"mini-css-extract-plugin": "^2.4.4",
56+
"null-loader": "^4.0.0",
6757
"react-refresh": "^0.11.0",
58+
"resolve-url-loader": "^3.1.1",
59+
"sass": "^1.43.4",
60+
"sass-loader": "^12.3.0",
61+
"sass-resources-loader": "^2.1.0",
62+
"style-loader": "^3.3.1",
63+
"url-loader": "^4.0.0",
6864
"webpack-dev-server": "^4.9.0"
6965
},
7066
"browser": {

0 commit comments

Comments
 (0)