Simplify record types

Author: alexeyr

node_package/src/Authenticity.ts

@@ -9,7 +9,7 @@ export default {
     return null;
   },
 
-  authenticityHeaders(otherHeaders: { [id: string]: string } = {}): AuthenticityHeaders {
+  authenticityHeaders(otherHeaders: Record<string, string> = {}): AuthenticityHeaders {
     return Object.assign(otherHeaders, {
       'X-CSRF-Token': this.authenticityToken(),
       'X-Requested-With': 'XMLHttpRequest',

node_package/src/ComponentRegistry.ts

@@ -8,7 +8,7 @@ export default {
   /**
    * @param components { component1: component1, component2: component2, etc. }
    */
-  register(components: { [id: string]: ReactComponentOrRenderFunction }): void {
+  register(components: Record<string, ReactComponentOrRenderFunction>): void {
     Object.keys(components).forEach((name) => {
       if (componentRegistry.has(name)) {
         console.warn('Called register for component that is already registered', name);

node_package/src/ReactOnRails.client.ts

@@ -46,11 +46,11 @@ ctx.ReactOnRails = {
    * find you components for rendering.
    * @param components (key is component name, value is component)
    */
-  register(components: { [id: string]: ReactComponentOrRenderFunction }): void {
+  register(components: Record<string, ReactComponentOrRenderFunction>): void {
     ComponentRegistry.register(components);
   },
 
-  registerStore(stores: { [id: string]: StoreGenerator }): void {
+  registerStore(stores: Record<string, StoreGenerator>): void {
     this.registerStoreGenerators(stores);
   },
 
@@ -60,7 +60,7 @@ ctx.ReactOnRails = {
    * the setStore API is different in that it's the actual store hydrated with props.
    * @param storeGenerators (keys are store names, values are the store generators)
    */
-  registerStoreGenerators(storeGenerators: { [id: string]: StoreGenerator }): void {
+  registerStoreGenerators(storeGenerators: Record<string, StoreGenerator>): void {
     if (!storeGenerators) {
       throw new Error(
         'Called ReactOnRails.registerStoreGenerators with a null or undefined, rather than ' +
@@ -172,7 +172,7 @@ ctx.ReactOnRails = {
    * @returns {*} header
    */
 
-  authenticityHeaders(otherHeaders: { [id: string]: string } = {}): AuthenticityHeaders {
+  authenticityHeaders(otherHeaders: Record<string, string> = {}): AuthenticityHeaders {
     return Authenticity.authenticityHeaders(otherHeaders);
   },
 

node_package/src/StoreRegistry.ts

@@ -9,7 +9,7 @@ export default {
    * Register a store generator, a function that takes props and returns a store.
    * @param storeGenerators { name1: storeGenerator1, name2: storeGenerator2 }
    */
-  register(storeGenerators: { [id: string]: StoreGenerator }): void {
+  register(storeGenerators: Record<string, StoreGenerator>): void {
     Object.keys(storeGenerators).forEach((name) => {
       if (storeGeneratorRegistry.has(name)) {
         console.warn('Called registerStore for store that is already registered', name);

node_package/src/registerServerComponent/server.ts

@@ -30,7 +30,7 @@ import { ReactComponent } from '../types';
  * });
  * ```
  */
-const registerServerComponent = (components: { [id: string]: ReactComponent }) => {
+const registerServerComponent = (components: Record<string, ReactComponent>) => {
   ReactOnRails.register(components);
 };
 

node_package/src/types/index.ts

@@ -33,7 +33,8 @@ export interface RailsContext {
   httpAcceptLanguage: string;
 }
 
-type AuthenticityHeaders = { [id: string]: string } & {
+// not strictly what we want, see https://github.com/microsoft/TypeScript/issues/17867#issuecomment-323164375
+type AuthenticityHeaders = Record<string, string> & {
   'X-CSRF-Token': string | null;
   'X-Requested-With': string;
 };
@@ -167,10 +168,10 @@ export interface Root {
 export type RenderReturnType = void | Element | Component | Root;
 
 export interface ReactOnRails {
-  register(components: { [id: string]: ReactComponentOrRenderFunction }): void;
+  register(components: Record<string, ReactComponentOrRenderFunction>): void;
   /** @deprecated Use registerStoreGenerators instead */
-  registerStore(stores: { [id: string]: StoreGenerator }): void;
-  registerStoreGenerators(storeGenerators: { [id: string]: StoreGenerator }): void;
+  registerStore(stores: Record<string, StoreGenerator>): void;
+  registerStoreGenerators(storeGenerators: Record<string, StoreGenerator>): void;
   getStore(name: string, throwIfMissing?: boolean): Store | undefined;
   getOrWaitForStore(name: string): Promise<Store>;
   getOrWaitForStoreGenerator(name: string): Promise<StoreGenerator>;
@@ -180,7 +181,7 @@ export interface ReactOnRails {
   reactOnRailsComponentLoaded(domId: string): void;
   reactOnRailsStoreLoaded(storeName: string): void;
   authenticityToken(): string | null;
-  authenticityHeaders(otherHeaders: { [id: string]: string }): AuthenticityHeaders;
+  authenticityHeaders(otherHeaders: Record<string, string>): AuthenticityHeaders;
   option(key: string): string | number | boolean | undefined;
   getStoreGenerator(name: string): StoreGenerator;
   setStore(name: string, store: Store): void;