Skip to content

Commit 237cd5a

Browse files
ihabadhamclaude
andcommitted
Fix install_js_dependencies to use system() calls instead of run()
During rebase conflict resolution, the method incorrectly kept run() calls instead of adopting master's enhanced system() calls. This was causing CI test failures due to package manager installation issues. Changes: - Use system("yarn", "install") instead of run "yarn install" - Use system("pnpm", "install") instead of run "pnpm install" - Use system("npm", "install") instead of run "npm install" This combines master's enhanced implementation with our method organization improvements. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent f177299 commit 237cd5a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lib/generators/react_on_rails/base_generator.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,13 +196,13 @@ def add_dev_dependencies
196196
def install_js_dependencies
197197
# Detect which package manager to use
198198
success = if File.exist?(File.join(destination_root, "yarn.lock"))
199-
run "yarn install"
199+
system("yarn", "install")
200200
elsif File.exist?(File.join(destination_root, "pnpm-lock.yaml"))
201-
run "pnpm install"
201+
system("pnpm", "install")
202202
elsif File.exist?(File.join(destination_root, "package-lock.json")) ||
203203
File.exist?(File.join(destination_root, "package.json"))
204204
# Use npm for package-lock.json or as default fallback
205-
run "npm install"
205+
system("npm", "install")
206206
else
207207
true # No package manager detected, skip
208208
end

0 commit comments

Comments
 (0)