Skip to content

Commit 1d3bfea

Browse files
justin808claude
andcommitted
Fix SCSS rule detection to use proper filename in test
Changed rule.test.test('.scss') to rule.test.test('example.scss') because webpack SCSS rules typically use patterns like /\.scss$/ which require a full filename to match properly, not just the extension. The string '.scss' doesn't match /\.scss$/ but 'example.scss' does. This fixes the test failures where CSS wasn't being loaded, making React components appear as empty divs (not visible). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 89ca7c2 commit 1d3bfea

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

react_on_rails_pro/spec/dummy/config/webpack/commonWebpackConfig.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const baseClientWebpackConfig = generateWebpackConfig();
2929

3030
// Add sass-resources-loader to all SCSS rules
3131
baseClientWebpackConfig.module.rules.forEach((rule) => {
32-
if (Array.isArray(rule.use) && rule.test && rule.test.test('.scss')) {
32+
if (Array.isArray(rule.use) && rule.test && rule.test.test('example.scss')) {
3333
rule.use.push(sassLoaderConfig);
3434
}
3535
});

spec/dummy/config/webpack/commonWebpackConfig.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const sassLoaderConfig = {
2525
baseClientWebpackConfig.module.rules.forEach((rule) => {
2626
if (Array.isArray(rule.use)) {
2727
// Add sass-resources-loader to all SCSS rules (both .scss and .module.scss)
28-
if (rule.test && rule.test.test('.scss')) {
28+
if (rule.test && rule.test.test('example.scss')) {
2929
rule.use.push(sassLoaderConfig);
3030
}
3131

0 commit comments

Comments
 (0)