Lock RuboCop gem versions and fix all linting issues

- Lock rubocop-performance to 1.23.1
- Lock rubocop-rails to 2.29.1
- Lock rubocop-rspec to 3.4.0
- Auto-fix all 23 correctable RuboCop offenses
- Update code to follow current RuboCop standards

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: justin808

Gemfile

@@ -75,9 +75,9 @@ group :development, :test do
   ################################################################################
   # Linters and Security
   gem "rubocop", "1.69", require: false
-  gem "rubocop-performance", "~> 1.13"
-  gem "rubocop-rails"
-  gem "rubocop-rspec", "~> 3.3"
+  gem "rubocop-performance", "1.23.1", require: false
+  gem "rubocop-rails", "2.29.1", require: false
+  gem "rubocop-rspec", "3.4.0", require: false
   # Critical that require: false be set! https://github.com/brigade/scss-lint/issues/278
   gem "scss_lint", require: false
 

Gemfile.lock

@@ -512,9 +512,9 @@ DEPENDENCIES
   redis (~> 5.0)
   rspec-rails (~> 6.0.0)
   rubocop (= 1.69)
-  rubocop-performance (~> 1.13)
-  rubocop-rails
-  rubocop-rspec (~> 3.3)
+  rubocop-performance (= 1.23.1)
+  rubocop-rails (= 2.29.1)
+  rubocop-rspec (= 3.4.0)
   sass-rails
   scss_lint
   sdoc

app/controllers/comments_controller.rb

@@ -102,7 +102,7 @@ def inline_form
   private
 
   def set_comments
-    @comments = Comment.all.order("id DESC")
+    @comments = Comment.order("id DESC")
   end
 
   # Use callbacks to share common setup or constraints between actions.
@@ -116,6 +116,6 @@ def new_comment
 
   # Never trust parameters from the scary internet, only allow the white list through.
   def comment_params
-    params.require(:comment).permit(:author, :text)
+    params.expect(comment: %i[author text])
   end
 end

app/controllers/pages_controller.rb

@@ -41,7 +41,7 @@ def rescript; end
   private
 
   def set_comments
-    @comments = Comment.all.order("id DESC")
+    @comments = Comment.order("id DESC")
   end
 
   def comments_json_string

config/initializers/react_on_rails.rb

@@ -22,9 +22,7 @@
   #
   # This configuration tells React on Rails where to find bundles in test environment.
   # Without this, it defaults to public/webpack/test/ instead of public/packs/
-  if Rails.env.test?
-    config.generated_assets_dir = File.join(Rails.root, "public", "packs")
-  end
+  config.generated_assets_dir = Rails.public_path.join("packs").to_s if Rails.env.test?
 
   ################################################################################
   # CLIENT RENDERING OPTIONS

lib/tasks/ci.rake

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-if Rails.env.development? || Rails.env.test?
+if Rails.env.local?
   # See tasks/linters.rake
 
   task js_tests: :environment do

lib/tasks/daily.rake

@@ -2,8 +2,8 @@
 
 task daily: :environment do
   t = 1.day.ago
-  older_comments = Comment.where("created_at < ?", t)
-  newer_comments = Comment.where("created_at >= ?", t)
+  older_comments = Comment.where(created_at: ...t)
+  newer_comments = Comment.where(created_at: t..)
   puts "Deleting #{older_comments.count} comments older than #{t}"
   puts "Keeping #{newer_comments.count} comments newer than #{t}"
   older_comments.delete_all

spec/rails_helper.rb

@@ -35,7 +35,7 @@
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
-Dir[Rails.root.join("spec/support/**/*.rb")].sort.each { |f| require f }
+Rails.root.glob("spec/support/**/*.rb").sort.each { |f| require f }
 
 RSpec.configure do |config|
   config.include FactoryBot::Syntax::Methods

spec/rescript/rescript_spec.rb

@@ -46,41 +46,41 @@
     end
 
     it "comment count increases with successful form submission" do
-      initital_comment_count = Comment.all.count
+      initital_comment_count = Comment.count
       new_comment_count = initital_comment_count + 1
       fill_in author_field, with: comment.author
       fill_in text_field, with: comment.text
       click_button("Post")
 
       page.driver.browser.manage.timeouts.implicit_wait = 1
 
-      expect(Comment.all.count).to equal(new_comment_count)
+      expect(Comment.count).to equal(new_comment_count)
     end
 
     it "comment count remains the same when author field is empty" do
-      initial_comment_count = Comment.all.count
+      initial_comment_count = Comment.count
       fill_in text_field, with: comment.text
       click_button("Post")
 
       expect(page).to have_text(/Can't save the comment!/)
-      expect(Comment.all.count).to equal(initial_comment_count)
+      expect(Comment.count).to equal(initial_comment_count)
     end
 
     it "comment count remains the same when text field is empty" do
-      initial_comment_count = Comment.all.count
+      initial_comment_count = Comment.count
       fill_in author_field, with: comment.author
       click_button("Post")
 
       expect(page).to have_text(/Can't save the comment!/)
-      expect(Comment.all.count).to equal(initial_comment_count)
+      expect(Comment.count).to equal(initial_comment_count)
     end
 
     it "comment count remains the same when both form fields are empty" do
-      initial_comment_count = Comment.all.count
+      initial_comment_count = Comment.count
       click_button("Post")
 
       expect(page).to have_text(/Can't save the comment!/)
-      expect(Comment.all.count).to equal(initial_comment_count)
+      expect(Comment.count).to equal(initial_comment_count)
     end
   end
 end

spec/stimulus/turbo_spec.rb

@@ -41,41 +41,41 @@
     end
 
     it "adds a new comment to the page and database" do
-      initital_comment_count = Comment.all.count
+      initital_comment_count = Comment.count
       new_comment_count = initital_comment_count + 1
       fill_in author_field, with: comment.author
       fill_in text_field, with: comment.text
       click_button("Post")
 
       expect(page).to have_css("h2", text: comment.author)
       expect(page).to have_css("p", text: comment.text)
-      expect(Comment.all.count).to equal(new_comment_count)
+      expect(Comment.count).to equal(new_comment_count)
     end
 
     it "comment count remains the same when author field is empty" do
-      initial_comment_count = Comment.all.count
+      initial_comment_count = Comment.count
       fill_in text_field, with: comment.text
       click_button("Post")
 
       expect(page).to have_text("Author: can't be blank")
-      expect(Comment.all.count).to equal(initial_comment_count)
+      expect(Comment.count).to equal(initial_comment_count)
     end
 
     it "comment count remains the same when text field is empty" do
-      initial_comment_count = Comment.all.count
+      initial_comment_count = Comment.count
       fill_in author_field, with: comment.author
       click_button("Post")
 
       expect(page).to have_text("Text: can't be blank")
-      expect(Comment.all.count).to equal(initial_comment_count)
+      expect(Comment.count).to equal(initial_comment_count)
     end
 
     it "comment count remains the same when both form fields are empty" do
-      initial_comment_count = Comment.all.count
+      initial_comment_count = Comment.count
       click_button("Post")
 
       expect(page).to have_text("Author: can't be blank")
-      expect(Comment.all.count).to equal(initial_comment_count)
+      expect(Comment.count).to equal(initial_comment_count)
     end
   end
 end