Skip to content

Good configuration ignored when coupled with bad configuration #1470

Closed
@joeyparrish

Description

Have you read the FAQ and checked for duplicate open issues?: Yes

What version of Shaka Player are you using?: v2.4.1

Can you reproduce the issue with our latest release version?: yes

Can you reproduce the issue with the latest code from master?: yes

Are you using the demo app or your own custom app?: demo app

If custom app, can you reproduce the issue using our demo app?: N/A

What browser and OS are you using?: ChromeOS 68

What are the manifest and license server URIs?: N/A

What did you do?

  1. Open the demo app without playing anything.
  2. Open the JS console.
  3. Run:
player.configure({
  badKey: 'foo',
  drm: {
    servers: {
      'com.widevine.alpha': 'foo',
    },
  },
});
  1. Then run:
player.getConfiguration().drm.servers

What did you expect to happen?

I expect player.configure() to return false, because of the bad config key.
I expect player.getConfiguration().drm.servers to return {'com.widevine.alpha': 'foo'}, because that part of the config is still valid.

What actually happened?

player.configure() returns false, as expected.
player.getConfiguration().drm.servers returns {}, because the entire config was ignored/rejected.

Metadata

Assignees

Labels

status: archivedArchived and locked; will not be updatedtype: bugSomething isn't working correctly

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions