Skip to content

Moved React to devDependencies #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2017
Merged

Moved React to devDependencies #81

merged 3 commits into from
Jul 4, 2017

Conversation

zachrnolan
Copy link
Contributor

Fixes issue #59

@zachrnolan zachrnolan mentioned this pull request Jul 3, 2017
Closed
@shahen94
Copy link
Owner

shahen94 commented Jul 4, 2017

@zachrnolan can you please move react to devDependency . It needed for unit tests

@zachrnolan
Copy link
Contributor Author

@shahen94 moved react to devDependencies, tests are now passing. My bad!

@zachrnolan zachrnolan changed the title Moved React to peerDependencies Moved React to devDependencies Jul 4, 2017
shahen94
shahen94 approved these changes Jul 4, 2017
View reviewed changes
Copy link
Owner

@shahen94 shahen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @zachrnolan !

@shahen94 shahen94 merged commit 2a33c1d into shahen94:master Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahen94 shahen94 shahen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachrnolan @shahen94